Add DatasetProvider interface. The clear advantage of this over simply renaming DatasetProviderBase to DatasetProvider is that current uses of DatasetProviderBase do not break (implementing DatasetProviders still extend DPBase).#431
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
83dc208 to
14f227c
Compare
14f227c to
732113a
Compare
0039107 to
e184213
Compare
…y renaming DatasetProviderBase to DatasetProvider is that current uses of DatasetProviderBase do not break (implementing DatasetProviders still extend DPBase). PiperOrigin-RevId: 479216470
e184213 to
ca71a61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DatasetProvider interface. The clear advantage of this over simply renaming DatasetProviderBase to DatasetProvider is that current uses of DatasetProviderBase do not break (implementing DatasetProviders still extend DPBase).