Skip to content

fix(auth): ensure proxy OAuth URL includes response_type cleanly#699

Open
jeevan6996 wants to merge 1 commit intogoogleworkspace:mainfrom
jeevan6996:fix/695-proxy-auth-response-type
Open

fix(auth): ensure proxy OAuth URL includes response_type cleanly#699
jeevan6996 wants to merge 1 commit intogoogleworkspace:mainfrom
jeevan6996:fix/695-proxy-auth-response-type

Conversation

@jeevan6996
Copy link
Copy Markdown

Summary

  • remove whitespace artifacts from the manually constructed proxy OAuth authorization URL so query parameter keys are emitted exactly as expected
  • ensure response_type=code is always present and not prefixed by encoded/leading spaces when proxy login flow is used
  • extend unit coverage for build_proxy_auth_url to assert clean response_type formatting and include a patch changeset

Fixes #695

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 11, 2026

🦋 Changeset detected

Latest commit: 05c28aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the proxy OAuth authorization URL was being constructed with unintended whitespace, causing potential failures in the authentication flow. By flattening the URL string construction, the change ensures that query parameters are emitted cleanly and consistently.

Highlights

  • URL Formatting: Removed whitespace artifacts from the manually constructed proxy OAuth URL to ensure query parameters are correctly parsed.
  • Testing: Added unit test assertions to verify that the response_type parameter is correctly formatted without leading spaces or encoding issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes OAuth proxy login URL formatting by consolidating the URL string into a single line within the build_proxy_auth_url function. This change ensures that parameters like response_type=code are correctly preserved without unintended whitespace or encoding issues. Unit tests have also been updated to verify the presence of the correct parameters and the absence of malformed spacing. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auth login fails with "missing response_type" on Desktop OAuth client (v0.22.5, macOS)

2 participants