fix(auth): ensure proxy OAuth URL includes response_type cleanly#699
fix(auth): ensure proxy OAuth URL includes response_type cleanly#699jeevan6996 wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 05c28aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the proxy OAuth authorization URL was being constructed with unintended whitespace, causing potential failures in the authentication flow. By flattening the URL string construction, the change ensures that query parameters are emitted cleanly and consistently. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes OAuth proxy login URL formatting by consolidating the URL string into a single line within the build_proxy_auth_url function. This change ensures that parameters like response_type=code are correctly preserved without unintended whitespace or encoding issues. Unit tests have also been updated to verify the presence of the correct parameters and the absence of malformed spacing. I have no feedback to provide.
Summary
response_type=codeis always present and not prefixed by encoded/leading spaces when proxy login flow is usedbuild_proxy_auth_urlto assert cleanresponse_typeformatting and include a patch changesetFixes #695