Skip to content

fix(services): add apps-script alias for the script service#707

Open
nuthalapativarun wants to merge 1 commit intogoogleworkspace:mainfrom
nuthalapativarun:fix/script-service-apps-script-alias
Open

fix(services): add apps-script alias for the script service#707
nuthalapativarun wants to merge 1 commit intogoogleworkspace:mainfrom
nuthalapativarun:fix/script-service-apps-script-alias

Conversation

@nuthalapativarun
Copy link
Copy Markdown

Problem

helpers/mod.rs already routes "apps-script" to ScriptHelper:

"script" | "apps-script" => Some(Box::new(script::ScriptHelper)),

But the service registry (services.rs) only lists "script" as an alias:

aliases: &["script"],

So gws apps-script ... returns Unknown service 'apps-script' and all the
existing helper code is unreachable via that alias.

Fix

Adds "apps-script" to the aliases array so resolve_service("apps-script")
resolves to ("script", "v1"), consistent with what the helper router already
expects.

Also adds a test asserting both "script" and "apps-script" resolve to the
same service entry.

Fixes #625

helpers/mod.rs already routes "apps-script" to ScriptHelper, but the
service registry only listed "script", so `gws apps-script ...` returned
"Unknown service". Adds the alias to the registry so both names resolve
to ("script", "v1") identically.

Also adds a test asserting both aliases resolve correctly.

Fixes googleworkspace#625
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 12, 2026

🦋 Changeset detected

Latest commit: 2e71246

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the 'apps-script' alias was unreachable despite being defined in the helper routing logic. By updating the service registry to include this alias, the command-line interface can now correctly resolve and execute commands using the 'apps-script' identifier.

Highlights

  • Service Alias Update: Added 'apps-script' to the service registry aliases to ensure consistency with existing helper routing.
  • Verification: Added a new unit test to verify that both 'script' and 'apps-script' correctly resolve to the same service entry.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the "apps-script" alias to the script service registry in crates/google-workspace/src/services.rs and includes a corresponding unit test to verify the resolution of both "script" and "apps-script" aliases. A changeset file has also been added to document this fix. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

script service not registered in services.rs — helper and setup exist but are unreachable

2 participants