fix(services): add apps-script alias for the script service#707
fix(services): add apps-script alias for the script service#707nuthalapativarun wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
helpers/mod.rs already routes "apps-script" to ScriptHelper, but the
service registry only listed "script", so `gws apps-script ...` returned
"Unknown service". Adds the alias to the registry so both names resolve
to ("script", "v1") identically.
Also adds a test asserting both aliases resolve correctly.
Fixes googleworkspace#625
🦋 Changeset detectedLatest commit: 2e71246 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the 'apps-script' alias was unreachable despite being defined in the helper routing logic. By updating the service registry to include this alias, the command-line interface can now correctly resolve and execute commands using the 'apps-script' identifier. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the "apps-script" alias to the script service registry in crates/google-workspace/src/services.rs and includes a corresponding unit test to verify the resolution of both "script" and "apps-script" aliases. A changeset file has also been added to document this fix. I have no feedback to provide.
Problem
helpers/mod.rsalready routes"apps-script"toScriptHelper:But the service registry (
services.rs) only lists"script"as an alias:So
gws apps-script ...returnsUnknown service 'apps-script'and all theexisting helper code is unreachable via that alias.
Fix
Adds
"apps-script"to thealiasesarray soresolve_service("apps-script")resolves to
("script", "v1"), consistent with what the helper router alreadyexpects.
Also adds a test asserting both
"script"and"apps-script"resolve to thesame service entry.
Fixes #625