chain/ethereum: Include contract address and block number in ABI decode error messages#6490
Open
sueun-dev wants to merge 1 commit intographprotocol:masterfrom
Open
Conversation
…de error messages Add contract address and block number context to ABI decode error messages to help debugging. Fixes graphprotocol#3404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3404
When ABI decoding fails for Ethereum call handlers, the error messages only show the function ABI and raw bytes. Adding the contract address and block number makes it easier to correlate failures with specific on-chain calls.
Changes in
chain/ethereum/src/data_source.rs:call.to(contract address) andcall.block_numbercall.to,call.block_number, and raw input bytes