Skip to content

cleanup old rtl residue - do not apply direction to grid-stack-rtl #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielgindi wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −9
Open

cleanup old rtl residue - do not apply direction to grid-stack-rtl #3269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion demo/right-to-left(rtl).html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ <h1>RTL Demo</h1>
{x: 6, y: 0, w: 2, h: 2},
];
items.forEach((item, i) => item.content = 'item ' + i);
let grid = GridStack.init({rtl: true, children: items});
let grid = GridStack.init({
rtl: true,
float: true,
children: items,
resizable: {handles: 'sw,se'}
});

function addWidget() {
let w = {
Expand Down
7 changes: 0 additions & 7 deletions src/gridstack.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,6 @@
position: relative;
}

.grid-stack-rtl {
direction: ltr;
Copy link
Copy Markdown
Member

@adumesny adumesny Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you don't want that set by default because ??? you're more knowlegable on this than me so I will defer this to you. Just trying to understand to amke sure things work out of the box

Copy link
Copy Markdown
Member

@adumesny adumesny Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielgindi please explain

> .grid-stack-item {
direction: rtl;
}
}

.grid-stack-placeholder > .placeholder-content {
background-color: rgba(0,0,0,0.1);
margin: 0;
Expand Down
2 changes: 1 addition & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ export interface GridStackOptions {
row?: number;

/**
* if true turns grid to RTL. Possible values are true, false, 'auto' (default?: 'auto')
* if true turns grid to RTL, and applies the `grid-stack-rtl class`. Possible values are true, false, 'auto' (default?: 'auto')
* See [example](http://gridstack.github.io/gridstack.js/demo/right-to-left(rtl).html)
*/
rtl?: boolean | 'auto';
Expand Down