Please test: OSD stats fixes and code cleanup#11506
Open
breadoven wants to merge 3 commits intoiNavFlight:maintenance-9.xfrom
Open
Please test: OSD stats fixes and code cleanup#11506breadoven wants to merge 3 commits intoiNavFlight:maintenance-9.xfrom
breadoven wants to merge 3 commits intoiNavFlight:maintenance-9.xfrom
Conversation
|
Test firmware build ready — commit Download firmware for PR #11506 234 targets built. Find your board's
|
sensei-hacker
changed the title
Collaborator
Author
|
Multi-page stats was tested using HITL (set to PAL) and single-page (HD) was tested using Avatar. Everything seems to work as expected including the Auto swap function and manual stick commands to swap pages. Would be useful for someone to test HD Zero I guess given it has less rows than Avatar. DJI WTF should be fine if Avatar works given it has more rows available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following issues related to OSD stats page display:
An issue with OSD stats not displaying properly due to a mix up with columns and rows which caused additional stats to always be added at the bottom of the screen even when there weren't enough rows available leading to display problems.
An issue which prevented Rx stats being displayed correctly when CRSF used.
An issue causing unreliable "Saving Settings" messages.
In addition to the above the PR generally cleans up stats code formatting inconsistencies and layout.