[pull] main from danny-avila:main#80
Merged
Merged
Conversation
…ered index (#159) `fixThoughtSignatures` correlates each AI message with a Gemini-formatted "model" content block to re-attach `thoughtSignature` onto functionCall parts. The pre-fix code filtered the AI-message list down to only those WITH a non-empty `additional_kwargs.signatures`, then walked the filtered array in lockstep with the unfiltered modelContents. As soon as any prior AI message lacked signatures (a plain-text "Hello!" turn before a tool-using turn, in the most common case), the indices desynced and the toolcall AI message got matched against the wrong content block — leaving the real functionCall sigless and triggering a 400 from Vertex on the follow-up call. Live repro on `gemini-3.1-flash-lite-preview` (mirrors LibreChat#13006): turn-1 plain text + turn-2 bash_tool functionCall → `Google request failed with status code 400` after the tool result is sent back. With the fix, the round-trip completes. Walk every AI message by position, skip non-signature ones inline so the later messages still align with their model content blocks. Added unit tests covering the failure case + multi-turn dispatch + idempotence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )