libvirt: do not set MTU on public/direct interfaces#3404
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes libvirt.uplink failures on newer libvirt (notably Ubuntu 24.04/libvirt 10.x) by ensuring the generated Vagrant/libvirt configuration does not attempt to set MTU on public/direct (macvtap) interfaces, which libvirt rejects.
Changes:
- Emit
:libvirt__mtu => 9500only for:private_network(bridge-based) links. - Stop emitting
:libvirt__mtufor:public_network(direct/macvtap) links, avoiding the libvirt 10.x “setting MTU on interface type direct is not supported” error.
ipspace
approved these changes
May 20, 2026
Owner
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
Thank you! The only thing I changed: I moved the MTU setting into the existing "private network" block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to this issue