Libvirt machine type#3406
Merged
Merged
Conversation
ipspace
approved these changes
May 18, 2026
Owner
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
Perfect. Thank you! Now we have to reimplement the vSRX fix to set the libvirt.machine_type in device-specific provider data ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this was said in #3397 (comment) regarding configuring the machine_type for libvirt.
Still dealing with the aftermath of my upgrade from 20.04 to 24.04, this time it's my F5 load balancer vagrant box that was affected — a linux device as far as netlab is concerned. Very similar to the Juniper VSRX issue and the fix is also changing the
machine_typefor that device.I didn't want to change it for all libvirt linux hosts, as it could have a wider blast radius, and it seems to be something quite specific for my use case. For that reason, I thought having an option to select the
machine_typein the node attribute would work quite well.