doc: Prism theme audit — fidelity review across diagram families#137
Closed
doc: Prism theme audit — fidelity review across diagram families#137
Conversation
Co-authored-by: jongalloway <68539+jongalloway@users.noreply.github.com> Agent-Logs-Url: https://github.com/jongalloway/DiagramForge/sessions/c1811517-c87f-46d8-b115-fe55edf4eb1b
Co-authored-by: jongalloway <68539+jongalloway@users.noreply.github.com> Agent-Logs-Url: https://github.com/jongalloway/DiagramForge/sessions/c1811517-c87f-46d8-b115-fe55edf4eb1b
Copilot
AI
changed the title
[WIP] Review Prism theme behavior across diagram types
doc: Prism theme audit — fidelity review across diagram families
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prism's white-fill + 4-stop rainbow border-gradient identity renders correctly through the standard
AppendGradientDefspath but is silently broken in several diagram types that either setrender:noGradient=truewith palette-derived fills or useNodePaletteas direct fill colors — both of which collapse to white-on-white in Prism.Audit document:
doc/prism-audit.mdFull findings with SVG fixture evidence and code-level root causes for every diagram type in the review set.
Categorization
TryResolveXyChartColors, bypassingNodePalette; Prism border gradient is presentCategory C root causes
DefaultLayoutEngine.Snake.cs):node.FillColor = palette[i]andsegmentColors.Add(palette[i])useNodePalettedirectly. In Prism every entry is#FFFFFF→ invisible tube and circles on white background.DefaultLayoutEngine.TabList.cs): all three layouts setrender:noGradient=trueand derive accent fills fromVibrant(palette[i], 2.x).Vibrantof pure white is still white → accent blocks, title bars, and number tabs are entirely invisible.DefaultLayoutEngine.Target.cs): ring and center nodes carryrender:noGradient=truewith explicitly set solid colors fromThemePaletteResolver.BuildRingColors;AppendTargetRingNode/AppendTargetCardNodenever consulttheme.BorderGradientStops.Proposed follow-up issues (detailed in audit doc)
BorderGradientStopsas segment colorsAccentColor/ firstBorderGradientStoptheme.BorderGradientStopswhen availableBorderGradientStopsas series palette whenUseGradients=false && UseBorderGradients=trueWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphqlThis comment is the deliverable for #128. I reviewed every diagram type in the suggested set by comparing SVG fixture output across themes and tracing the rendering code paths in
SvgNodeWriter.cs, `SvgRenderSupport.cs`` (http block)📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.