var MatchedRoutePathParam = "$matchedRoutePath" changed declaration to const MatchedRoutePathParam#379
Open
LeoDiKadyrov wants to merge 1 commit intojulienschmidt:masterfrom
Conversation
Author
|
Oh wow, unexpected monday surprise. Appreciate that you directed your attention to my PR. Will call it out in the PR body |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I only suggested it due to following reasons:
All tests that are originally in master repo passed green. When I was going through the code it just confused me a bit, that a variable only used in router.go and not really mutated anywhere declared as
var. Sorry if it's too small to have anyone attention and a whole PR open for it.UPD 23.03.2026
Breaking Change: Switching
MatchedRoutePathParamfromvartoconst. Any downstream code that previously reassignedhttprouter.MatchedRoutePathParamwill no longer compile.