fix(core): migrate FileSerde to binary ION API#368
Open
nkwiatkowski wants to merge 1 commit into
Open
Conversation
…ry ION support Migrate from deprecated Reader/Writer-based FileSerde methods to the new InputStream/OutputStream API, enabling binary ION serialization in Kestra 2.0. Bump kestraVersion to 1.3.19 which includes the compatibility layer. Refs: kestra-io/kestra#3155
Contributor
Contributor
Tests report quick summary:success ✅ > tests: 218, success: 218, skipped: 0, failed: 0 unfold for details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileTransformand its tests from deprecatedReader/Writer-basedFileSerdemethods to the newInputStream/OutputStreamAPIkestraVersionfrom1.3.16to1.3.19(includes the InputStream/OutputStream compatibility layer)Changes
FileTransform.java:BufferedWriter/FileWriter→BufferedOutputStream/FileOutputStream,BufferedReader/InputStreamReader→BufferedInputStream,Writer→OutputStreamparameterFileTransformTest.java:BufferedReader/InputStreamReader→BufferedInputStream,FileSerde.reader()→FileSerde.read(), proper try-with-resources on input streamsgradle.properties:kestraVersion1.3.16 → 1.3.19Test plan
./gradlew :plugin-script:compileJava :plugin-script:compileTestJavapassesRefs: kestra-io/kestra#3155