feat: allow fallback when oss storage is crash#677
Open
fatelei wants to merge 2 commits intolanggenius:mainfrom
Open
feat: allow fallback when oss storage is crash#677fatelei wants to merge 2 commits intolanggenius:mainfrom
fatelei wants to merge 2 commits intolanggenius:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a fallback OSS storage mechanism and an on-demand local plugin launching system. Key additions include the FallbackOSS wrapper to handle primary storage failures and a middleware-integrated method to launch local plugins when needed. Feedback identifies logic errors in the FallbackOSS implementation regarding object existence, deletion, and listing that could lead to data inconsistency. Additionally, there are significant concerns regarding the synchronous nature of plugin launching within HTTP middleware, which could lead to request timeouts and resource exhaustion, and a recommendation to replace magic strings with constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #670
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Please provide any additional context that would help reviewers understand the changes.