Skip to content

feat: allow fallback when oss storage is crash#677

Open
fatelei wants to merge 2 commits intolanggenius:mainfrom
fatelei:issue-670
Open

feat: allow fallback when oss storage is crash#677
fatelei wants to merge 2 commits intolanggenius:mainfrom
fatelei:issue-670

Conversation

@fatelei
Copy link
Copy Markdown
Contributor

@fatelei fatelei commented Apr 4, 2026

Description

fix #670

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request go Pull requests that update go code plugin-daemon labels Apr 4, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a fallback OSS storage mechanism and an on-demand local plugin launching system. Key additions include the FallbackOSS wrapper to handle primary storage failures and a middleware-integrated method to launch local plugins when needed. Feedback identifies logic errors in the FallbackOSS implementation regarding object existence, deletion, and listing that could lead to data inconsistency. Additionally, there are significant concerns regarding the synchronous nature of plugin launching within HTTP middleware, which could lead to request timeouts and resource exhaustion, and a recommendation to replace magic strings with constants.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code plugin-daemon size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PluginDaemonInternalServerError: no available node, plugin runtime not found

1 participant