Add macro event declarations#1867
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event_defsdeclarations toverity_contractCompilationModel.eventsChecks
lake build Compiler.CompilationModelFeatureTestlake build Contracts.Smoke Compiler.CompilationModelFeatureTest Contracts.MacroTranslateInvariantTestlake build PrintAxiomspython3 scripts/generate_print_axioms.py --checkpython3 scripts/check_axioms.pygit diff --checkNote
Medium Risk
Extends the
verity_contractmacro surface syntax and spec generation to carry event definitions, which may affect downstream compilation/ABI outputs for contracts using the macro. Changes are additive but touch core macro translation paths.Overview
verity_contractnow supports anevent_defssection with per-parameter@indexedannotations, and macro translation threads these declarations through parsing/elaboration intoCompilationModel.spec.events.Adds translation support in
Verity/Macro/Translate.lean(newEventDecl/EventParamDeclparsing and model term generation) and updates the contract elaborator to pass event declarations into spec generation.Updates
Compiler/CompilationModelFeatureTest.leanwith a smoke contract that declaresTransferand asserts the resulting spec carries correct indexed vs unindexed event metadata.Reviewed by Cursor Bugbot for commit 9f5e2de. Bugbot is set up for automated code reviews on this repo. Configure here.