Allow array values in executable emit calls#1872
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contracts.EventArgso executableemitcalls can accept scalar words and array values in one argument listVerification
Note
Medium Risk
Changes the
Contracts.emitAPI and its coercions, which could subtly affect executable event traces for existing contracts, especially around dynamic array arguments. The change is conceptually small but touches a commonly used surface in contract stubs/tests.Overview
Extends executable event emission to accept a mixed argument list of scalar words and dynamic arrays by introducing
Contracts.EventArgand updatingemitto map arrays to a dynamic-array length placeholder in the event trace.Adds macro smoke coverage for emitting events with array parameters, including emitting an allocated memory array, and updates event-metadata assertions to cover the new array-typed events.
Reviewed by Cursor Bugbot for commit 5dfe314. Bugbot is set up for automated code reviews on this repo. Configure here.