Skip to content

fixed blockchain.transaction.get verbose parameter declared required instead of optional #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eynhaender wants to merge 1 commit into from
Closed

fixed blockchain.transaction.get verbose parameter declared required instead of optional #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/bitcoin/server/interfaces/electrum.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ struct electrum_methods

method<"blockchain.transaction.broadcast", string_t>{ "raw_tx" },
method<"blockchain.transaction.broadcast_package", value_t, optional<false>>{ "raw_txs", "verbose" },
method<"blockchain.transaction.get", string_t, boolean_t>{ "tx_hash", "verbose" },
method<"blockchain.transaction.get", string_t, optional<false>>{ "tx_hash", "verbose" },
method<"blockchain.transaction.get_merkle", string_t, number_t>{ "tx_hash", "height" },
method<"blockchain.transaction.id_from_pos", number_t, number_t, optional<false>>{ "height", "tx_pos", "merkle" },

Expand Down
5 changes: 3 additions & 2 deletions test/protocols/electrum/electrum_transactions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,15 +214,16 @@ BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__nonexistent_tx__not_f
BOOST_REQUIRE_EQUAL(response.at("error").as_object().at("code").as_int64(), not_found.value());
}

BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__missing_param__dropped)
BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__missing_verbose__defaults_false)
{
BOOST_REQUIRE(handshake(electrum::version::v1_0));

const auto& coinbase = *test::genesis.transactions_ptr()->front();
const auto tx0_hash = encode_hash(coinbase.hash(false));
const auto request = R"({"id":80,"method":"blockchain.transaction.get","params":["%1%"]})" "\n";
const auto response = get((boost::format(request) % tx0_hash).str());
REQUIRE_NO_THROW_TRUE(response.at("dropped").as_bool());
REQUIRE_NO_THROW_TRUE(response.at("result").is_string());
BOOST_REQUIRE_EQUAL(response.at("result").as_string(), encode_base16(coinbase.to_data(true)));
}

BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__extra_param__dropped)
Expand Down
Loading