Configurable HumanReadableName resolver#195
Open
tnull wants to merge 3 commits intolightningdevkit:mainfrom
Open
Configurable HumanReadableName resolver#195tnull wants to merge 3 commits intolightningdevkit:mainfrom
HumanReadableName resolver#195tnull wants to merge 3 commits intolightningdevkit:mainfrom
Conversation
Picks up support for resolving BIP 353 Human-Readable Names (ldk-node PR #630), which adds `Config::hrn_config` and the `HumanReadableNamesConfig` / `HRNResolverConfig` types. Co-Authored-By: HAL 9000
Exposes LDK Node's new `HumanReadableNamesConfig` via a new `[hrn]` section in `config.toml`. Users can pick between resolving BIP 353 names locally over DNS (`mode = "dns"`, the default) or via bLIP-32 (`mode = "blip32"`), and, when using DNS, optionally run as an HRN resolution service for the rest of the network. Defaults match LDK Node's: resolve via DNS against `8.8.8.8:53` with the resolution service disabled (enabling it requires the node to be announceable so others can route resolution requests to us). Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @benthecarman as a reviewer! |
benthecarman
requested changes
Apr 21, 2026
Collaborator
benthecarman
left a comment
benthecarman
left a comment
There was a problem hiding this comment.
would be nice to one day add http support as well but mostly looks good!
Addresses review feedback on the initial HRN configuration commit: - Construct `HRNResolverConfig::Dns` explicitly inside the DNS arm of the mode match rather than relying on `HumanReadableNamesConfig`'s default being DNS. If LDK Node's default ever changes (e.g., to accommodate new resolver modes), the DNS-specific settings are still applied when the user explicitly selects DNS mode instead of being silently dropped. - Reject configs that set `dns_server_address` or `enable_resolution_service` under `mode = "blip32"`, since these options would otherwise be silently ignored and leave users thinking they took effect. - Fall back to port 53 when a DNS server address is given without an explicit port (e.g., `dns_server_address = "1.1.1.1"` is treated as `"1.1.1.1:53"`), matching the convention for DNS. Generated with the assistance of AI (Claude).
Collaborator
Author
|
Addressed pending feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump LDK Node and add configurable HRN resolution.