qdl: Add support for multiple include folders using a list#197
qdl: Add support for multiple include folders using a list#197WilliamBright-IMD wants to merge 2 commits intolinux-msm:masterfrom
Conversation
WilliamBright-IMD
force-pushed
the
feature/Multiple_Include_Folders
branch
from
d136299 to
b6cff7f
Compare
…r files. This is particularly useful for yocto builds since binaries are generated into three folders whereas currently QDL only supports searching for files in two folders. Signed-off-by: William Bright <William.Bright@imd-tec.com>
WilliamBright-IMD
force-pushed
the
feature/Multiple_Include_Folders
branch
from
b6cff7f to
bd47e4a
Compare
|
Hi @lumag , I don't have permissions to add a reviewer so I wonder if this PR has gone unnoticed. |
|
Problem description sounds reasonable to me. Would it make sense to use list.h to carry the list of include dirs instead of making it an array? Approving the workflow to get the build checks to run for now. |
Use list_head from list.h to carry include directories instead of a hardcoded 32-entry array, removing the arbitrary limit on the number of -i options. Formatting issues of the previous patch were also fixed in the process of making this change. Signed-off-by: William Bright <William.Bright@imd-tec.com>
Thanks, I have pushed another commit with formatting corrections and the list.h change. I wasn't' sure if you want to fold this commit with the previous commit or not, so I will leave it up to you. |
|
@andersson is it worth me rebasing these patches? Is there anything else that will need changing before these can be considered |
WilliamBright-IMD
changed the title
2 participants
This is particularly useful for yocto builds since binaries are generated into three folders whereas currently QDL only supports searching for files in two folders (if you pass a single -i argument)
You can use this new feature like below:
qdl -i folder1 -i folder2