usb: add PID 0x90db and refactor PID check#218
Open
mukeshojha-linux wants to merge 1 commit intolinux-msm:masterfrom
Open
usb: add PID 0x90db and refactor PID check#218mukeshojha-linux wants to merge 1 commit intolinux-msm:masterfrom
mukeshojha-linux wants to merge 1 commit intolinux-msm:masterfrom
Conversation
Add PID 0x90db used by some Qualcomm targets in EDL mode. Also refactor usb_try_open() to use usb_is_edl_pid() instead of a duplicate hardcoded PID list, so future PID additions only need a single change. Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Collaborator
|
It used to be that this list gave us "definitive" answer that the device is in EDL mode, but if I read correctly this isn't a PID reserved for EDL mode. Is there some other check we should include here? |
Contributor
Author
If I remember correctly, I did the change as device was not detecting in crash dump mode after crash., there device manager was showing (0x90db as pid) let me recheck this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PID 0x90db used by some Qualcomm targets in EDL mode. Also refactor usb_try_open() to use usb_is_edl_pid() instead of a duplicate hardcoded PID list, so future PID additions only need a single change.