Skip to content

Revert "require CanManageAgentSession grant for remote session (#5487)"#5714

Merged
theomonnom merged 1 commit into
mainfrom
revert-can-manage-agent-session
May 12, 2026
Merged

Revert "require CanManageAgentSession grant for remote session (#5487)"#5714
theomonnom merged 1 commit into
mainfrom
revert-can-manage-agent-session

Conversation

@chenghao-mou
Copy link
Copy Markdown
Member

Summary

  • Reverts commit 2de7aa0 which added CanManageAgentSession permission checks to the remote session transport
  • Restores the previous remote_identity-based filtering behavior in RoomSessionTransport
  • Removes the IncomingMessage wrapper and _send_response helper, reverting to direct AgentSessionMessage passing

Test plan

  • Verify remote session connections work without CanManageAgentSession grants
  • Run test_session_host.py tests

Made with Cursor

@chenghao-mou chenghao-mou requested a review from a team May 12, 2026 18:28
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@theomonnom theomonnom merged commit 66725a8 into main May 12, 2026
25 checks passed
@theomonnom theomonnom deleted the revert-can-manage-agent-session branch May 12, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants