Skip to content

fix build#231

Merged
UziTech merged 2 commits intomainfrom
v18-1
Apr 7, 2026
Merged

fix build#231
UziTech merged 2 commits intomainfrom
v18-1

Conversation

@UziTech
Copy link
Copy Markdown
Member

@UziTech UziTech commented Apr 7, 2026

No description provided.

@UziTech UziTech merged commit 3d36965 into main Apr 7, 2026
6 checks passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package version to 18.0.0-1, upgrades the 'marked' and 'marked-repo' dependencies to version 18.0.0, and modifies the TypeScript configuration to set the root directory to './src'. A critical issue was identified where the 'package-lock.json' file is out of sync with the new version in 'package.json', which could lead to build failures in CI environments.

{
"name": "@markedjs/testutils",
"version": "18.0.0-0",
"version": "18.0.0-1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version in package-lock.json (both at the root and in the packages[""] entry) is still set to 17.0.5-0, which is out of sync with the new version 18.0.0-1 in package.json. This discrepancy will cause npm ci to fail in CI environments. Please run npm install to ensure the lockfile is correctly updated and synchronized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant