Fix Linux Python SDK, Pydantic warning and updates the ExecuteCommandWithCallback signature#593
Merged
baijumeswani merged 10 commits intomainfrom Apr 6, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SDK runtime compatibility across Python and JS, focusing on native binary discovery/installation (especially on Linux) and minor DTO/FFI interoperability fixes.
Changes:
- Adjust Python native binary discovery/install logic to account for Linux ORT/GenAI packaging differences.
- Update Python Pydantic model config to allow
model_*field names without protected-namespace conflicts. - Modify JS CoreInterop streaming callback FFI signature/behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sdk/python/src/detail/utils.py | Updates native library discovery and foundry-local-install package selection with Linux-specific branches. |
| sdk/python/src/detail/model_data_types.py | Adds Pydantic ConfigDict(protected_namespaces=()) to prevent model_* field-name conflicts. |
| sdk/python/requirements.txt | Switches to platform-specific ORT/GenAI dependencies for Linux vs non-Linux. |
| sdk/js/src/detail/coreInterop.ts | Changes Koffi callback prototype for streaming command callbacks and returns a status value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sheetalarkadam
previously approved these changes
Apr 5, 2026
prathikr
previously approved these changes
Apr 6, 2026
baijumeswani
changed the title
baijumeswani
changed the title
prathikr
approved these changes
Apr 6, 2026
baijumeswani
added a commit
that referenced
this pull request
Apr 6, 2026
…WithCallback signature (#593) This pull-request has 3 changes: - Fixes the pydantic warnings by intializing `model_config = ConfigDict(protected_namespaces=())` - Fixes Linux python sdk by depending on onnxruntime-gpu and onnxruntime-genai-cuda on Linux - Updates the callback signature because FLC updated the callback signature to return an int instead of void. Returning 1 means that the execute command operation should be cancelled, whereas 0 means to continue. The actual model download cancellation support is not part of this pull-request. Will add it in a subsequent PR. --------- Co-authored-by: Prathik Rao <prathikrao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request has 3 changes:
model_config = ConfigDict(protected_namespaces=())