Preserve roles when converting messages to seed prompts#1508
Merged
rlundeen2 merged 1 commit intomicrosoft:mainfrom Apr 13, 2026
Merged
Preserve roles when converting messages to seed prompts#1508rlundeen2 merged 1 commit intomicrosoft:mainfrom
rlundeen2 merged 1 commit intomicrosoft:mainfrom
Conversation
romanlutz
approved these changes
Mar 18, 2026
Contributor
romanlutz
left a comment
There was a problem hiding this comment.
This looks correct. I'm wondering why we had that here...
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Preserves API-compatible message roles during Message → SeedPrompt conversion, preventing loss of roles like system, developer, and tool.
Changes:
- Update
SeedPrompt.from_messages()to usemessage.api_roledirectly instead of collapsing non-assistant roles touser. - Add regression tests covering
system,developer,tool, andsimulated_assistant → assistantnormalization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/unit/models/test_seed.py | Adds parametric regression test to ensure supported roles are preserved (and simulated_assistant normalizes to assistant). |
| pyrit/models/seeds/seed_prompt.py | Adjusts conversion logic to preserve message.api_role when creating SeedPrompt records. |
rlundeen2
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Messageobjects toSeedPromptrecordssimulated_assistant -> assistantnormalization by relying onmessage.api_rolesystem,developer,tool, andsimulated_assistantProblem
SeedPrompt.from_messages()currently collapses every non-assistant message role touser. That loses supported roles such assystem,developer, andtoolwhen messages are converted into seed prompts.Validation
.venv/bin/pytest tests/unit/models/test_seed.py -q.venv/bin/ruff check pyrit/models/seeds/seed_prompt.py tests/unit/models/test_seed.py