Fix code scanning path injection alerts in media endpoint#1607
Merged
romanlutz merged 1 commit intomicrosoft:mainfrom Apr 14, 2026
Merged
Fix code scanning path injection alerts in media endpoint#1607romanlutz merged 1 commit intomicrosoft:mainfrom
romanlutz merged 1 commit intomicrosoft:mainfrom
Conversation
Refactor serve_media_async to use os.path.realpath + str.startswith sanitization pattern (recognized by CodeQL py/path-injection) instead of pathlib resolve + is_relative_to. Extract validation into a dedicated _validate_media_path helper. Resolves code scanning alerts microsoft#19, microsoft#20, microsoft#21. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the /api/media\ endpoint to resolve 3 CodeQL \py/path-injection\ alerts (#19, #20, #21).
Changes
Security model (unchanged)
All existing guards are preserved:
esults_path\
All 12 existing tests pass without modification.