manticore: added sanity tests for manticore driver#4320

Open

sidchintamaneni wants to merge 1 commit intomicrosoft:mainfrom

sidchintamaneni:siddharthc/manticore-tests

Collaborator

sidchintamaneni commented Mar 6, 2026

Tested by running the following command on a VM

LISA_RPM_PATH=/path/to/manticore-hwe-*.rpm \
  lisa run -r lisa/microsoft/runbook/ready.yml \
    -v "public_address:<VM_IP>" \
    -v "user_name:azureuser" \
    -v "admin_private_key_file:/path/to/key" \
    -v tier:debug \
    -v "case:verify_azihsm.*"


          manticore: added sanity tests for manticore driver

173a098

sidchintamaneni requested review from LiliDeng and johnsongeorge-w as code owners

March 6, 2026 17:46

sidchintamaneni mentioned this pull request

[Draft]Manticore LISA test (untested) #4307

Closed

netsweng commented Mar 12, 2026

This is very RPM specific. Admittedly, the focus is on Mariner, but we also want to be able to run the Lisa tests on Ubuntu.
This test should just install packages from a well-known pkg repo like tux-dev and not require a manual step to copy something onto the system first.
There are versions hardwired into this script which creates ongoing maintenance, or the test will not be running against the latest product. These versions should be determined dynamically.
The tests that are implemented are good general driver tests, but we also need tests that use the azihsm test tools for deeper coverage.

Collaborator Author

sidchintamaneni commented Mar 12, 2026

Agreed with all your points. This PR is created to initiate a conversation with LISA team.

we are relying on Manticore team to add functional tests since we are not familiar with what the driver does. Feel free to extend on top of these sanity tests or you can create a new PR and I'll close this one.

LiliDeng requested a review from Copilot

March 17, 2026 07:02

Copilot started reviewing on behalf of LiliDeng

March 17, 2026 07:03

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

This PR adds a new LISA test suite that validates the manticore-hwe RPM packaging for the azihsm out-of-tree kernel module on Azure Linux (CBL-Mariner), covering install, module load/unload behavior, and uninstall cleanup.

Changes:

Adds a new AziHsmRpmTest suite with phased test cases (installation, modinfo/load cycles, uninstallation).
Adds helpers to locate the RPM on-node (env var, URL tarball download+extract, fallback globs) and parse module/kernel metadata from the RPM contents.
Adds optional kernel-hwe installation + reboot flow when the running kernel doesn’t match the module’s target kernel.

You can also share your feedback on Copilot code review. Take the survey.

lisa/microsoft/testsuites/core/azihsm_module.py

Comment on lines +316 to +322

+                      # Unload module first if loaded (pre-uninstall safety)
+                      node.execute(
+                          "modprobe -r azihsm", sudo=True, no_error_log=True
+                      )
+                      node.execute(
+                          f"rpm -evh {self.PKG_NAME}", sudo=True, no_error_log=True
+                      )

lisa/microsoft/testsuites/core/azihsm_module.py

Comment on lines +215 to +217

+                      result = node.execute(
+                          f"rpm -qp --queryformat '%{{VERSION}} %{{RELEASE}}' {rpm_path}",
+                          sudo=True,

lisa/microsoft/testsuites/core/azihsm_module.py

Comment on lines +232 to +236

+                      result = node.execute(
+                          f"rpm -qpl {rpm_path} | grep '\\.ko$'",
+                          sudo=True,
+                          shell=True,
+                      )

lisa/microsoft/testsuites/core/azihsm_module.py

Comment on lines +179 to +181

+                          result = node.execute(
+                              f"test -f {env_path}", sudo=True, no_error_log=True
+                          )

lisa/microsoft/testsuites/core/azihsm_module.py

Comment on lines +517 to +519

		# Clear dmesg
		node.execute("dmesg -c", sudo=True)

LiliDeng reviewed

View reviewed changes

lisa/microsoft/testsuites/core/azihsm_module.py

+                  )
+                  def verify_azihsm_rpm_installation(
+                      self, node: Node, log: Logger
+                  ) -> None:

Collaborator

LiliDeng Mar 17, 2026

Add a parameter variable: Dict[str, Any], and make all os environment variables be set from runbook. Then get the value in below way.

oot_source_url = variables.get("LISA_OOT_SOURCE_URL", "")

LiliDeng reviewed

View reviewed changes

lisa/microsoft/testsuites/core/azihsm_module.py


		# Test 1 - RPM installs without errors
		self._install_rpm(node, log, rpm_path)

Collaborator

LiliDeng Mar 17, 2026

Add all common code into one method, then reuse it.

LiliDeng reviewed

View reviewed changes

lisa/microsoft/testsuites/core/azihsm_module.py

+                          expected_exit_code=0,
+                      )
+                      pkg_full = result.stdout.strip()
+                      log.info(f"Package in RPM DB: {pkg_full}")

Collaborator

LiliDeng Mar 17, 2026

Use rpm tool to install the package

rpm_tool = node.tools[Rpm]
rpm_tool.is_valid_package
rpm_tool.install_local_package

LiliDeng reviewed

View reviewed changes

lisa/microsoft/testsuites/core/azihsm_module.py

+                              time.sleep(1)
+                          # Clear dmesg
+                          node.execute("dmesg -c", sudo=True)

Collaborator

LiliDeng Mar 17, 2026

use dmesg tool

netsweng commented Mar 17, 2026

Note, the code I am working on for the functional tests is using the distro agnostic package_install API instead of calling rpm directly. This will make it more portable in the long run.

Collaborator Author

sidchintamaneni commented Mar 17, 2026

Note, the code I am working on for the functional tests is using the distro agnostic package_install API instead of calling rpm directly. This will make it more portable in the long run.

can you cite your work here and close this PR in favor of that

netsweng commented Mar 17, 2026

I will do that, but I want to incorporate the tests here into my code before I offer a replacement PR to make sure they do not get lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet