Package, Dependencies and Config Path Updates to Support Azure Linux 4.0 by MadhurAggarwal · Pull Request #4399 · microsoft/lisa

MadhurAggarwal · 2026-03-27T13:14:16Z

Description

Support for CBL Mariner 4.0 Version
Added 4.0 specific Path (/usr/lib/systemd/logind.conf) for file /etc/systemd/logind.conf
Added Default Value (dnf) for dnf tool name
Updated List of Packages & Dependencies to install for 4.0

Related Issue

Type of Change

Checklist

Description is filled in above
No credentials, secrets, or internal details are included
Peer review requested (if not, add required peer reviewers after raising PR)
Tests executed and results posted below

Test Validation

Key Test Cases:

Impacted LISA Features:

Tested Azure Marketplace Images:

Test Results

Image	VM Size	Result
		PASSED / FAILED / SKIPPED

Copilot

Pull request overview

This PR extends LISA’s Azure Linux (CBL Mariner) compatibility to cover 4.0 by reusing existing AZL3 implementations and adjusting OS-level configuration paths/defaults to match AZL4 layout and tooling expectations.

Changes:

Treat Azure Linux 4.0 as compatible with existing AZL3 implementations for GrubConfig and Fips.
Update CBLMariner set_kill_user_processes() to use /usr/lib/systemd/logind.conf when /etc/systemd/logind.conf is absent (AZL4 path change).
Set a default value for CBLMariner’s _dnf_tool_name.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
lisa/tools/grub_config.py	Adds AZL 4.0 support in the GrubConfig factory + updates the unsupported-distro message.
lisa/tools/fips.py	Adds AZL 4.0 support in the FIPS factory + updates the unsupported-distro message.
lisa/operating_system.py	Defaults CBLMariner dnf tool name and adds AZL4 logind.conf path fallback for KillUserProcesses.

Copilot · 2026-03-27T13:21:46Z

lisa/operating_system.py

    def __init__(self, node: Any) -> None:
        super().__init__(node)
-        self._dnf_tool_name: str
+        self._dnf_tool_name: str = "dnf"


Setting _dnf_tool_name default to "dnf" can cause CBLMariner to run dnf before _initialize_package_installation() has had a chance to detect whether only tdnf is available. Since RPMDistro._install_packages/_uninstall_packages call _dnf_tool() without first calling _initialize_package_installation(), consider ensuring tool selection is initialized before any package operation (e.g., lazy-init inside _dnf_tool() or overriding _install_packages/_uninstall_packages to gate on _first_time_installation).

Copilot · 2026-03-27T13:21:47Z

lisa/operating_system.py

+        if not self._node.shell.exists(
+            self._node.get_pure_path(logind_conf)
+        ):
+            logind_conf = "/usr/lib/systemd/logind.conf"


The fallback to /usr/lib/systemd/logind.conf is not validated for existence. If neither /etc/systemd/logind.conf nor /usr/lib/systemd/logind.conf exists, sed -i will fail and this method will raise unexpectedly. Consider checking the fallback path too and either creating /etc/systemd/logind.conf (preferred) or raising a clear error/skip when systemd config is not present.

Suggested change

if not self._node.shell.exists(

self._node.get_pure_path(logind_conf)

):

logind_conf = "/usr/lib/systemd/logind.conf"

shell = self._node.shell

primary_path = self._node.get_pure_path(logind_conf)

if not shell.exists(primary_path):

fallback_logind_conf = "/usr/lib/systemd/logind.conf"

fallback_path = self._node.get_pure_path(fallback_logind_conf)

if shell.exists(fallback_path):

logind_conf = fallback_logind_conf

else:

# Neither primary nor fallback exist; create the primary config file

self._log.debug(

"Neither /etc/systemd/logind.conf nor /usr/lib/systemd/logind.conf "

"exists. Creating /etc/systemd/logind.conf."

)

self._node.execute(

"mkdir -p /etc/systemd && touch /etc/systemd/logind.conf",

sudo=True,

shell=True,

expected_exit_code=0,

expected_exit_code_failure_message=(

"Failed to create /etc/systemd/logind.conf"

),

)

Copilot · 2026-03-27T13:21:47Z

lisa/operating_system.py

        sed.append(
            text="KillUserProcesses=no",
-            file="/etc/systemd/logind.conf",
+            file=logind_conf,
            sudo=True,
        )
        self._node.tools[Service].restart_service("systemd-logind")


set_kill_user_processes() always uses sed.append(...) and restarts systemd-logind, so repeated calls will keep appending duplicate KillUserProcesses=no lines and repeatedly restart the service (this is also currently invoked from _initialize_package_installation). Making the change idempotent (e.g., replace existing KillUserProcesses= or check if the setting already exists before editing/restarting) would avoid config bloat and unnecessary service churn.

Copilot · 2026-03-27T13:21:47Z

lisa/tools/fips.py


        raise UnsupportedDistroException(
-            os=node.os, message="FIPS tool only supported on CBLMariner 2.0 and 3.0."
+            os=node.os, message="FIPS tool only supported on CBLMariner 2.0, 3.0 and 4.0."


The UnsupportedDistroException(...) call is now long enough to violate the repo's flake8 max-line-length = 88 setting, which will fail linting. Please wrap the arguments across multiple lines (similar to grub_config.py) so each line stays within 88 chars.

Suggested change

os=node.os, message="FIPS tool only supported on CBLMariner 2.0, 3.0 and 4.0."

os=node.os,

message="FIPS tool only supported on CBLMariner 2.0, 3.0 and 4.0.",

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

lisa/microsoft/testsuites/xfstests/xfstests.py

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

lisa/microsoft/testsuites/ltp/ltp.py

Copilot · 2026-03-27T19:16:21Z

lisa/operating_system.py

+        # Azure Linux 4.0 moved logind.conf to /usr/lib/systemd/
+        logind_conf = "/etc/systemd/logind.conf"
+        if not self._node.shell.exists(
+            self._node.get_pure_path(logind_conf)
+        ):
+            logind_conf = "/usr/lib/systemd/logind.conf"
        sed.append(
            text="KillUserProcesses=no",
-            file="/etc/systemd/logind.conf",
+            file=logind_conf,


Editing the vendor config at /usr/lib/systemd/logind.conf is brittle (package updates may overwrite it) and may not be the correct override location for systemd. Prefer writing the setting to /etc/systemd/logind.conf (create it if missing) or a drop-in under /etc/systemd/logind.conf.d/, and keep /usr/lib untouched.

lisa/microsoft/testsuites/xfstests/xfstests.py

MadhurAggarwal · 2026-03-28T03:54:23Z

lisa/tools/fio.py

                "blktrace",
                "libaio",
                "bc",
+                "sysstat",


sysstat is available in 4.0 but fails to install due to missing pcp

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

lisa/microsoft/testsuites/xfstests/xfstests.py

MadhurAggarwal · 2026-03-28T04:32:43Z

lisa/microsoft/testsuites/xfstests/xfstests.py

            )

+        # Temporary Workaround to test xfs in Azurelinux 4.0
+        # DO NOT MERGE


This seems to be a bug (missing symlink in pkg-config package) in 4.0 Alpha image, added a workaround to test xfs. will remove this once upstream gets fixed.

MadhurAggarwal · 2026-04-02T14:41:29Z

lisa/microsoft/testsuites/xfstests/xfstests.py

            )

+        # Temporary Workaround to test xfs in Azurelinux 4.0
+        # DO NOT MERGE


This is only issue in Alpha1 image.
Fix is present in azurelinux-stage1-compact package. installing that package creates this symlink. in stage2 image this change would not be required.

MadhurAggarwal added 3 commits March 27, 2026 17:44

Added new logind_conf path for Azurelinux 4.0

7017e69

Added Default value for dnf_tool_name for azl_4.0

e9e766f

Support Azl 4.0 to not raise Unsupported Distro Exception

2b9dae1

Copilot AI review requested due to automatic review settings March 27, 2026 13:14

Copilot started reviewing on behalf of MadhurAggarwal March 27, 2026 13:16 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

MadhurAggarwal added 2 commits March 27, 2026 19:28

Updated 4.0 Depdendency List for xfs test

4519db0

TEMP: pkg-config workaround for AzL 4.0

d45422f

Copilot AI review requested due to automatic review settings March 27, 2026 14:33

Copilot started reviewing on behalf of MadhurAggarwal March 27, 2026 14:36 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

lisa/microsoft/testsuites/xfstests/xfstests.py Show resolved Hide resolved

MadhurAggarwal added 2 commits March 28, 2026 00:14

Update Package List for Azl_4.0 in ltp test-suite

dd61b0e

Added symlink workaround for pkg-config to test kernel-ltp suite

8cc5d89

Copilot AI review requested due to automatic review settings March 27, 2026 19:08

Copilot started reviewing on behalf of MadhurAggarwal March 27, 2026 19:10 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

MadhurAggarwal added 2 commits March 28, 2026 01:23

Updated Package Dependency for lisa-perf tests

3138cdc

Update Package List for Azl_4.0 in multiple tests for lisa-gen2

59ade0f

Copilot AI review requested due to automatic review settings March 28, 2026 03:52

MadhurAggarwal commented Mar 28, 2026

View reviewed changes

Copilot started reviewing on behalf of MadhurAggarwal March 28, 2026 03:56 View session

Copilot AI reviewed Mar 28, 2026

View reviewed changes

lisa/microsoft/testsuites/xfstests/xfstests.py Show resolved Hide resolved

MadhurAggarwal changed the title ~~Madagg/azurelinux 4.0 changes~~ Package, Dependencies and Config Path Updates to Support Azure Linux 4.0 Mar 28, 2026

MadhurAggarwal commented Mar 28, 2026

View reviewed changes

MadhurAggarwal commented Apr 2, 2026

View reviewed changes

-        if not self._node.shell.exists(
-            self._node.get_pure_path(logind_conf)
-        ):
-            logind_conf = "/usr/lib/systemd/logind.conf"
+        shell = self._node.shell
+        primary_path = self._node.get_pure_path(logind_conf)
+        if not shell.exists(primary_path):
+            fallback_logind_conf = "/usr/lib/systemd/logind.conf"
+            fallback_path = self._node.get_pure_path(fallback_logind_conf)
+            if shell.exists(fallback_path):
+                logind_conf = fallback_logind_conf
+            else:
+                # Neither primary nor fallback exist; create the primary config file
+                self._log.debug(
+                    "Neither /etc/systemd/logind.conf nor /usr/lib/systemd/logind.conf "
+                    "exists. Creating /etc/systemd/logind.conf."
+                )
+                self._node.execute(
+                    "mkdir -p /etc/systemd && touch /etc/systemd/logind.conf",
+                    sudo=True,
+                    shell=True,
+                    expected_exit_code=0,
+                    expected_exit_code_failure_message=(
+                        "Failed to create /etc/systemd/logind.conf"
+                    ),
+                )

	os=node.os, message="FIPS tool only supported on CBLMariner 2.0, 3.0 and 4.0."
	os=node.os,
	message="FIPS tool only supported on CBLMariner 2.0, 3.0 and 4.0.",

Conversation

MadhurAggarwal commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

Checklist

Test Validation

Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MadhurAggarwal Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

MadhurAggarwal Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

MadhurAggarwal Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MadhurAggarwal commented Mar 27, 2026 •

edited

Loading