Add policy for notifying authors of Localization Restriction#6156
Add policy for notifying authors of Localization Restriction#6156denelon merged 3 commits intomicrosoft:masterfrom
Conversation
Co-authored-by: Muhammad Danish <mdanishkhdev@gmail.com>
| The English resource file [**/en-us/winget.resw](https://github.com/microsoft/winget-cli/blob/master/src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw) is the only file contributors should edit for string changes. It feeds the Microsoft localization pipeline. The files under [Localization\Resources\<locale>\](https://github.com/microsoft/winget-cli/tree/master/Localization/Resources) are **automatically synced from Microsoft's internal localization system and must not be edited**. Any manual edits will be overwritten on the next sync. | ||
|
|
||
|
|
||
| Instead of this PR, it would be helpful if you could [open an issue](https://github.com/microsoft/winget-cli/issues/new?template=Documentation_Issue.yml) so the internal localization team can review it. For more information, please see the [Development Guide](https://github.com/microsoft/winget-cli/blob/master/doc/Developing.md#localization). |
There was a problem hiding this comment.
Maybe we should add an issue template for localization issues. It would be helpful to have things in the format we need to pass on to the localization team. Also, I'd change the wording from "so the internal localization team can review it" to something like "and we will forward it to the internal localization team for review". The localization team does not look at our GitHub issues, and I wouldn't want to create an expectation that there would be interaction from them here.
There was a problem hiding this comment.
@denelon would you be okay with adding a template for translation issues?
Inputs we'd want for an issue template (basically copying the internal loc bug template):
- Language(s)
- Issue type: Incorrect Translation / Consistency / Gender / Grammar / Terminology / Style / Fluency / Other
- Source string (optional)
- Current translated string (optional)
- Suggested translated string (optional)
- Description / additional details
- How to find the bug
- Screenshots (optional)
There was a problem hiding this comment.
I added a basic template for now, happy to update it with additional information
There was a problem hiding this comment.
Given we have to run through our localization process, and they may reject certain requests it might be good to let end users know that as well. @Trenly do you want me to approve this as is and do a separate PR to extend the template or do you want to add those other fields in this PR?
There was a problem hiding this comment.
@denelon - I'd prefer a separate PR just so we can at least get the policy working and tested, then introduce the friction of the additional template fields
4 participants
Microsoft Reviewers: Open in CodeFlow