Allow sync in async factories#197
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR resolves issue #196 by enabling AsyncFactory to accept both synchronous and asynchronous factory functions, while maintaining backward compatibility. The changes also update documentation and docstrings to reflect the new method naming conventions.
- Updates
AsyncFactoryto accept both sync and async factory functions using method overloads - Adds runtime detection using
inspect.isawaitable()to handle both sync and async factories appropriately - Updates documentation and comments to use the new method names (
resolve()andresolve_sync())
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| that_depends/providers/factories.py | Core implementation allowing sync factories in AsyncFactory with overloaded constructors and runtime awaitable detection |
| tests/providers/test_factories.py | New test cases verifying AsyncFactory works with sync creators and dependency injection |
| docs/providers/factories.md | Updated documentation explaining AsyncFactory now supports both sync and async creators |
| that_depends/providers/singleton.py | Updated docstring examples and comments to use new method names |
| that_depends/providers/selector.py | Updated docstring examples to use new method names |
| that_depends/providers/resources.py | Updated docstring examples to use new method names |
| that_depends/providers/object.py | Updated docstring examples to use new method names |
| that_depends/providers/local_singleton.py | Updated docstring examples to use new method names |
| that_depends/providers/context_resources.py | Updated docstring examples to use new method names |
| that_depends/providers/collection.py | Updated docstring examples to use new method names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #196