bolt: implement tx_add_input message codec#23
Merged
morehouse merged 1 commit intomorehouse:masterfrom Apr 30, 2026
Merged
Conversation
Contributor
Author
|
@morehouse picked up tx_add_input since the embedded prevtx field made it the most involved of the interactive-tx codecs. Would love a review when you get a chance. |
harsh04044
force-pushed
the
bolt/tx-add-input
branch
from
2b8012d to
c0af643
Compare
harsh04044
force-pushed
the
bolt/tx-add-input
branch
from
c0af643 to
1058cc3
Compare
ekzyis
suggested changes
Apr 6, 2026
ekzyis
suggested changes
Apr 6, 2026
morehouse
requested changes
Apr 6, 2026
Owner
morehouse
left a comment
morehouse
left a comment
There was a problem hiding this comment.
Thanks for tackling this. Main feedback:
- let's avoid depending on the
bitcoincrate for now - let's add support for the
tlvsfield - please structure the tests similarly to the other codecs (
open_channelis a good example)
harsh04044
force-pushed
the
bolt/tx-add-input
branch
from
1058cc3 to
600f6da
Compare
Contributor
Author
|
Updated: dropped the bitcoin crate dependency (prevtx is now Vec), added TxAddInputTlvs following the open_channel pattern, and restructured tests to match the other codecs with one test per truncated field. |
morehouse
requested changes
Apr 8, 2026
harsh04044
force-pushed
the
bolt/tx-add-input
branch
from
600f6da to
b419151
Compare
morehouse
requested changes
Apr 10, 2026
| } | ||
|
|
||
| #[test] | ||
| fn message_tx_add_input_roundtrip() { |
Owner
There was a problem hiding this comment.
Tests should be ordered by the message type number.
harsh04044
force-pushed
the
bolt/tx-add-input
branch
3 times, most recently
from
7470f73 to
e2d30df
Compare
morehouse
reviewed
Apr 22, 2026
Owner
morehouse
left a comment
morehouse
left a comment
There was a problem hiding this comment.
Looks good once these comments are addressed.
| } | ||
|
|
||
| /// Valid `TxAddInput` message for testing. | ||
| fn sample_tx_add_input() -> TxAddInput { |
Owner
There was a problem hiding this comment.
Let's move this helper function to directly before message_tx_add_input_roundtrip, for consistency.
Contributor
Author
There was a problem hiding this comment.
Moved to directly before message_tx_add_input_roundtrip.
harsh04044
force-pushed
the
bolt/tx-add-input
branch
2 times, most recently
from
6498f66 to
39aa70d
Compare
harsh04044
force-pushed
the
bolt/tx-add-input
branch
from
39aa70d to
f961086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
tx_add_inputmessage codec (type 0x0042) for BOLT 2 interactive transaction construction.The
prevtxfield carries a full consensus-encoded Bitcoin transaction, decoded usingbitcoin::consensus::deserializeand length-prefixed on the wire via theWireFormattrait.Includes encode/decode,
Messageenum integration, and tests covering roundtrip, truncation, and trailing bytes.Part of #5