feature(lsp): implements incremental file updates#298
Merged
baszalmstra merged 2 commits intoFeb 28, 2021
Conversation
baszalmstra
changed the title
baszalmstra
changed the title
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
==========================================
+ Coverage 80.80% 80.82% +0.01%
==========================================
Files 240 241 +1
Lines 14584 14131 -453
==========================================
- Hits 11785 11421 -364
+ Misses 2799 2710 -89
Continue to review full report at Codecov.
|
Collaborator
|
Once the previous LSP PR is merged, can you rebase this? Quite a lot of files to re-review otherwise 😅 |
baszalmstra
force-pushed
the
feat/incremental_file_update
branch
from
dbc892f to
d36c727
Compare
baszalmstra
force-pushed
the
feat/incremental_file_update
branch
from
d36c727 to
13d722f
Compare
Wodann
reviewed
Feb 15, 2021
Collaborator
Wodann
left a comment
Wodann
left a comment
There was a problem hiding this comment.
Partially reviewed. I'll to review the remainder of this tomorrow
| } | ||
| #[test] | ||
| fn test_text_part_utf16() { | ||
| let text = "a\n❤️\nb"; |
Collaborator
There was a problem hiding this comment.
Is the emoji a UTF-16 character, but not a UTF-8 character?
Collaborator
There was a problem hiding this comment.
@baszalmstra, I'm just trying to understand the transition from UTF-8 to UTF-16
Wodann
requested changes
Feb 20, 2021
baszalmstra
force-pushed
the
feat/incremental_file_update
branch
from
db2129e to
12d006f
Compare
Wodann
approved these changes
Feb 27, 2021
baszalmstra
force-pushed
the
feat/incremental_file_update
branch
from
12d006f to
f9634bb
Compare
Wodann
added
type: feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the language server to receive incremental file updates when text is being modified in an editor.
I bumped the rowan and text_unit crates. They output syntax and text range a bit different which causes all the changes in a lot of tests.
I also cleaned up conversion from lsp types to our types. Functions are now split over the
to_lspandfrom_lspmodules.Depends on #293