feat: function calls#9
Merged
Wodann merged 17 commits intoOct 19, 2019
Merged
Conversation
Collaborator
Author
c1dbde2 to
d303207
Compare
ab56d2a to
f493184
Compare
da905a6 to
b4a5026
Compare
Wodann
requested changes
Oct 15, 2019
Collaborator
Wodann
left a comment
There was a problem hiding this comment.
Some general feedback:
- You use a lot of comments to describe what a section of code or line of code is doing. I am a big proponent of writing self-explanatory code. By moving that code to separate functions whose names describe what happens, you can write a much more concise function body using those function calls.
- Merge commits can break tools such as
git blame, so instead try to usegit rebase - Try to squash
fixcommits into their respectivefeaturecommits to clean up your history in a feature branch - Try to create separate PRs where possible and order them such that they can be applied consecutively. E.g. first merge a PR for temporary directories. Then merge the PR for function calls that uses the previous PR. It ends up being easier to review smaller PRs with related materials.
4beef16 to
c2b285f
Compare
Co-Authored-By: Wodann <Wodann@users.noreply.github.com>
c2b285f to
acd227d
Compare
Wodann
approved these changes
Oct 16, 2019
tdejager
suggested changes
Oct 16, 2019
Collaborator
tdejager
left a comment
There was a problem hiding this comment.
Very good, well done. There are a lot of files though so it was hard to do a thorough review, might be better to split some more stuff later on. But as always I'm impressed.
Wodann
reviewed
Oct 17, 2019
Wodann
reviewed
Oct 17, 2019
Co-Authored-By: Wodann <Wodann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use function calls in Mun.