Skip to content

fix: pin version for version for dev install when Trust downgrade is noticed#2644

Open
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:fix-override
Open

fix: pin version for version for dev install when Trust downgrade is noticed#2644
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:fix-override

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

@gameroman gameroman commented Apr 27, 2026

Closes #2643

Before

image

After

image

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 29, 2026 8:35am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 29, 2026 8:35am
npmx-lunaria Ignored Ignored Apr 29, 2026 8:35am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: df92723c-45ac-4614-97fc-09fc4f68e5c2

📥 Commits

Reviewing files that changed from the base of the PR and between cbf707c and 6cf0470.

📒 Files selected for processing (1)
  • app/components/Terminal/Install.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/components/Terminal/Install.vue

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Fixed dev install command generation so the version override is used when provided, ensuring the displayed install command reflects the chosen version.
    • Fixed clipboard copy behaviour so copied dev install commands match the corrected, user-selected version.

Walkthrough

The Terminal Install component now prefers installVersionOverride (when non-null) over requestedVersion for the version parameter used when building dev install command parts and when copying the dev install command to the clipboard.

Changes

Cohort / File(s) Summary
Version preference logic
app/components/Terminal/Install.vue
Changed getDevInstallPartsForPM and copyDevInstallCommand to pass installVersionOverride (when non-null) as the version argument to getInstallCommandParts/getInstallCommand, instead of always using requestedVersion.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title describes fixing version pinning for dev install when Trust downgrade is detected, directly matching the main change in the pull request.
Description check ✅ Passed The description includes before/after screenshots illustrating the version mismatch fix and references the linked issue #2643, demonstrating the fix in action.
Linked Issues check ✅ Passed The code changes implement version pinning for dev install using installVersionOverride when Trust downgrade is detected, directly addressing the bug requirement in issue #2643.
Out of Scope Changes check ✅ Passed All changes are focused on fixing version pinning for dev install in a single Vue component file, with no unrelated modifications present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gameroman gameroman changed the title fix: override for dev fix: pin version for version for dev install when Trust downgrade is noticed Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Terminal/Install.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: when Trust downgrade is noticed, the install version is not pinned for dev install

1 participant