[FIX] hr_holidays: New time off request crashed when listing time off type#5148
Open
covey-odoo wants to merge 1 commit into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-covey, it needs to be retargeted before it can be merged. |
|
Thanks for your work 😄 It looks good to me! Just one small change in the PR description -especially the commit message which is more important, as future developers will read it directly through git blame and it should be technically clear-; you could add details about the bug (a traceback caused by a missing argument, for instance). Also don't hesitate to follow the Git Guidelines for the commit title and body (missing module name in the title and task ID at the end). Please amend the commit message and the PR description and we're good to go ;) |
covey-odoo
force-pushed
the
master-time_off-traceback_on_time_off_type-covey
branch
from
5786e85 to
444d0f2
Compare
covey-odoo
changed the title
… type When requesting a new time off, the form view required the time type to be selected. If the user listed the time off types the app would crash. The search setup for that list required a validation function to run which held a bug. _search_virtual_remaining_leaves uses op (function to compare values, here >=). Function op requires two arguments to work, only 1 was given, causing the code to fail. task-6193474
covey-odoo
force-pushed
the
master-time_off-traceback_on_time_off_type-covey
branch
from
444d0f2 to
b15472c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When requesting a new time off, the form view required the time type to be selected. If the user listed the time off types the app would crash. The search setup for that list required a validation function to run which held a bug.