[FIX] hr_holidays: Accrual UX#5157
Open
raame-odoo wants to merge 1 commit into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-raame, it needs to be retargeted before it can be merged. |
raame-odoo
force-pushed
the
master-hr-onboarding-accrual_ux-raame
branch
from
e1c3baf to
a2868d9
Compare
amah-odoo
requested changes
May 11, 2026
amah-odoo
left a comment
amah-odoo
left a comment
There was a problem hiding this comment.
Thanks for you work ✨
some tiny comments
_get_selection_daysis used one more time in forcarryover_dayfield which should take the widget as well- I think it will be better to make the widget more flexible we can pass the month field as option or param from the xml view which allow as to sue the widget with any combination of day, month fields 👀
| registry.category("fields").add("accrual_day_dropdown", { | ||
| ...selectionField, | ||
| component: AccrualDaySelection, | ||
| }); No newline at end of file |
There was a problem hiding this comment.
missing EOF line. you could config your editor to add it by default
raame-odoo
force-pushed
the
master-hr-onboarding-accrual_ux-raame
branch
from
a2868d9 to
0372e9f
Compare
The selection field of days in the accrual plan milestones was always showing 31 days in the options regardless the month. A new JavaScript Class was created that extends the "SelecionField" to dynamically change the options and show the number of days depending on the month by accessing the month from props. Task: 6199932
raame-odoo
force-pushed
the
master-hr-onboarding-accrual_ux-raame
branch
from
0372e9f to
2576db8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selection field of days in the accrual plan milestones was always showing 31 days in the options regardless the month. A new JavaScript Class was created that extends the "SelecionField" to dynamically change the options and show the number of days depending on the month by accessing the month from props.
Task: 6199932