[FIX] mail: fix channel and role mention test in discuss app#5162
Open
alexkuhn wants to merge 1 commit into
Open
[FIX] mail: fix channel and role mention test in discuss app#5162alexkuhn wants to merge 1 commit into
alexkuhn wants to merge 1 commit into
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-owl3-migration, it needs to be retargeted before it can be merged. |
mcm-odoo
force-pushed
the
master-owl3-migration
branch
from
45ff4dd to
8b01dce
Compare
Partial revert of [1] Tests were wrongly adapted: the mentions have an extra space when adding the mentions in composer while composing, but the recovering part from starting edition of a message with already some mentions should not have the extra spaces (message content is trimmed). The tests were likely adapted because the tests were not passing due to prior steps that insert mention by hand in composer, and there was probably a issue in owl 3 code where the composer's input value of thread was reused with the extra whitespace. [1]: ecbf491
alexkuhn
force-pushed
the
master-owl3-migration-1-aku
branch
from
7b64d94 to
4832f21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial revert of 1
Tests were wrongly adapted: the mentions have an extra space when adding the mentions in composer while composing, but the recovering part from starting edition of a message with already some mentions should not have the extra spaces (message content is trimmed).
The tests were likely adapted because the tests were not passing due to prior steps that insert mention by hand in composer, and there was probably a issue in owl 3 code where the composer's input value of thread was reused with the extra whitespace.