[FIX] mail: fix test 'replying to message should only render relevant…#5163
Open
alexkuhn wants to merge 1 commit into
Open
[FIX] mail: fix test 'replying to message should only render relevant…#5163alexkuhn wants to merge 1 commit into
alexkuhn wants to merge 1 commit into
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-owl3-migration, it needs to be retargeted before it can be merged. |
mcm-odoo
force-pushed
the
master-owl3-migration
branch
from
45ff4dd to
8b01dce
Compare
… part' Test was adapted several time. Initially the patch of Message had: - onMounted - onPatched This was then changed to - onMounted - onRendered And this change over-estimated the rendering by at least 1, as onRendered also includes an extra render. But when this change was made, the counter was not increased in the assertion. Then the onMounted was removed, and the counter was reduced. The test is failing because the counter was changed from lower than 3 to lower than 2, but the initial change from onMounted/onPatched to onRendered should preserve the same counter of lower than 3. This commit fixes with the correct counter. Also the assertion on renderers on ActionSwiper were not necessarily made clear that this is related to the Message, so this commit adds comment to make it clear.
alexkuhn
force-pushed
the
master-owl3-migration-4-aku
branch
from
e006254 to
5ea6856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… part'
Test was adapted several time. Initially the patch of Message had:
This was then changed to
And this change over-estimated the rendering by at least 1, as onRendered also includes an extra render.
But when this change was made, the counter was not increased in the assertion.
Then the onMounted was removed, and the counter was reduced.
The test is failing because the counter was changed from lower than 3 to lower than 2, but the initial change from onMounted/onPatched to onRendered should preserve the same counter of lower than 3.
This commit fixes with the correct counter.
Also the assertion on renderers on ActionSwiper were not necessarily made clear that this is related to the Message, so this commit adds comment to make it clear.