Vcu update#129
Open
ConnorNovak wants to merge 19 commits into
Open
Conversation
1. Update steer & vel tuning constants to recent measured vals 2. Add auto-calculation of MAX & MIN signals for steer & vel - the result of this is to make safety thresholding in ackToCmd() functions more resilient to flipping the potentiometer. Safety thresholding code now compares MAX and MIN rather than HIGH and LOW. 3. Separate range conversion for velocity to match steering - the result of this change is to allow a centerpoint to be used that is not midway between the FWD and REV values - necessary now that the vehicle can move in reverse.
…op state while estop is true
… received topic as opposed to publishing on a 1-1 basis,\ncausing hysteresis runtime errors in the tractor on restart from estop.
1. Add custom DEBUG definitions to allow Header specification of which functions to debug. 2. Switch incoming ackermann msg to AckermannDriveStamped to monitor command latency. 3. Rearrange imports.
…src/gravl into lidarx_experiment
…vl into vcu-update
nathanestill
approved these changes
Mar 1, 2020
Collaborator
nathanestill
left a comment
nathanestill
left a comment
There was a problem hiding this comment.
I think it looks good. I couldn't find any errors. I added one comment to look at, but you can merge it.
| eStop->onStop(eStopTractor); | ||
| eStop->offStop(eStartTractor); | ||
| pinMode(ESTOP_RELAY_PIN, OUTPUT); | ||
| digitalWrite(ESTOP_RELAY_PIN, HIGH); // Stop tractor for safety |
Collaborator
There was a problem hiding this comment.
This is the only part that I'm curious of its functionality. I'm scared that it will have not be able to turn itself to high or something like that. Maybe you can reason it out to me on Tuesday.
Member
Author
|
Wow, I merged the stuff on the tractor once I saw these changes approved, but never finished this pull request. Sorry Nathan, my bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code tested on tractor