Add hosted shell response stream events#1800
Add hosted shell response stream events#1800raashish1601 wants to merge 3 commits intoopenai:masterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1aeda1a7d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/resources/responses/responses.ts
Outdated
| /** | ||
| * An opaque obfuscation token for sensitive command text. | ||
| */ | ||
| obfuscation: string; |
There was a problem hiding this comment.
Mark shell command obfuscation as optional
ResponseShellCallCommandDeltaEvent declares obfuscation as a required string, but Responses.StreamOptions.include_obfuscation in the same file documents that obfuscation fields can be disabled to reduce bandwidth. In that mode, response.shell_call_command.delta events may not carry this field, so consumers relying on this type can incorrectly assume it is always present and hit runtime undefined access. Model obfuscation as optional (or nullable) to keep the event type aligned with the documented stream option.
Useful? React with 👍 / 👎.
Summary
esponse.shell_call_command.* and
esponse.shell_call_output_content.*
Testing
Fixes #1750.