feat: add s3 xapi backfill#1208
Conversation
|
Thanks for the pull request, @Ian2012! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
7e1537a to
122cdc0
Compare
bmtcril
left a comment
There was a problem hiding this comment.
I'm super excited about this! Just a few comments.
| command: -w -c /etc/vector/vector.toml | ||
| volumes: | ||
| - ../../data/vector:/var/lib/vector | ||
| - ../plugins/aspects/apps/vector/local.toml:/etc/vector/vector.toml |
There was a problem hiding this comment.
Does this need to be writable?
There was a problem hiding this comment.
No, it never writes to it, and the watch option is for development only
There was a problem hiding this comment.
Ok, it looks like -w is on local here and the :ro got removed from the volume?
There was a problem hiding this comment.
Local should use this too as a vector restart didn't changed the vector run options. I had to delete the container with docker rm for changes to take effect
122cdc0 to
be98847
Compare
be98847 to
09a485a
Compare
bmtcril
left a comment
There was a problem hiding this comment.
I think this is about ready to go, we just need to make the changes to the container volumes, and I think we need to make clear in the doc that this only works when Vector is the backend.
This PR adds an optional s3 vector xapi sink which stores the events as a compressed json. It also adds a command to backfill the xapi events from that same s3 bucket with helpful options for backfill:
Setup the S3 sink:
Set the following options for the S3 sink:
The Vector S3 sink can be configure with:
Execute the backfill command: