Skip to content

Adds map of Venice 🛶#3935

Open
RickD004 wants to merge 1 commit into
openfrontio:mainfrom
RickD004:venice
Open

Adds map of Venice 🛶#3935
RickD004 wants to merge 1 commit into
openfrontio:mainfrom
RickD004:venice

Conversation

@RickD004
Copy link
Copy Markdown
Contributor

Description:

Adds map of Venice. A relatively small map (similar land area to World) for heavy trade and lots of boating.

Because of the very low difference of elevation of the zone, terrain is instead used to show buildings.

Map source from OpenStreetMap, already credited in CREDITS.md

Very requested map, with 2 discord posts suggesting it with +15 upvotes each

image

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Review Change Stack

Walkthrough

Adds Venice as a new regional map to the game. The type is registered in the game enum and category system, asset data defines 11 locations with coordinates, and the generator and server integrate Venice into map builds, translations, and public playlist scheduling with frequency 6.

Changes

Venice Map Onboarding

Layer / File(s) Summary
Game Type and Category Registration
src/core/game/Game.ts
Venice is added to the GameMapType enum and included in the regional category so the game recognizes it as a valid regional map choice.
Map Asset and Manifest Data
map-generator/assets/maps/venice/info.json, resources/maps/venice/manifest.json
Venice map data defines location metadata (Cannaregio, San Polo, San Marco, etc.) with coordinates and flags in info.json, and the complete manifest includes map dimensions, tile counts at multiple scales, and all location entries.
Generator, Translation, and Playlist Wiring
map-generator/main.go, resources/lang/en.json, src/server/MapPlaylist.ts
Venice is registered in the map generator so it can be processed and selected, a translation key is added for the UI, and playlist frequency is set to 6 to control how often Venice appears in randomly generated public playlists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openfrontio/OpenFrontIO#3920: Both PRs follow the same registration pattern—adding a new GameMapType entry to the enum and mapCategories.regional, plus adjusting FREQUENCY in MapPlaylist.ts.
  • openfrontio/OpenFrontIO#3929: Both PRs perform parallel type registration and category updates in src/core/game/Game.ts and frequency adjustments in src/server/MapPlaylist.ts.

Suggested reviewers

  • evanpelle
  • FloPinguin

Poem

A city on water now joins the game's fold, 🌊
Cannaregio, San Marco—eleven tales to be told,
Type and treasure, manifest and manifest strings,
Venice sails in at frequency six, where the Adriatic sings! ⚔️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a new Venice map to the project.
Description check ✅ Passed The description is directly related to the changeset, providing context about the Venice map addition, its purpose, and noting community demand.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/core/game/Game.ts`:
- Line 176: The change added a new map entry "Venice" in the Game map
enum/typing but no tests were added; add unit tests that cover the updated core
map typing/category behavior: create tests targeting the Game class (or the
enum/MapName type that now includes "Venice") to assert the new value exists,
that map/category resolution functions (e.g., any MapCategory or
getMapCategory/getMapByName functions) return the expected category/metadata for
"Venice", and update existing core tests that enumerate maps so they include
"Venice" to prevent regressions; ensure tests live alongside other core tests
and exercise both presence and category-resolution behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c8d7c9cc-486b-4159-8013-4a94c6057bc8

📥 Commits

Reviewing files that changed from the base of the PR and between b813792 and e3fde62.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/venice/image.png is excluded by !**/*.png
  • resources/maps/venice/map.bin is excluded by !**/*.bin
  • resources/maps/venice/map16x.bin is excluded by !**/*.bin
  • resources/maps/venice/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (7)
  • map-generator/assets/maps/venice/info.json
  • map-generator/main.go
  • resources/lang/en.json
  • resources/maps/venice/manifest.json
  • resources/maps/venice/thumbnail.webp
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts

Comment thread src/core/game/Game.ts
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development

Development

Successfully merging this pull request may close these issues.

1 participant