OCM-23823: migrate cs-ocm-resources-staging-main FVT to Prow#78690
OCM-23823: migrate cs-ocm-resources-staging-main FVT to Prow#78690dustman9000 wants to merge 2 commits intoopenshift:mainfrom
Conversation
Add Prow periodic for the OCM resources staging FVT job, migrating from Tekton/Konflux to the standard ocmci-based pattern.
openshift-ci-robot
added
the
jira/valid-reference
|
@dustman9000: This pull request references OCM-23823 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughRenames a shared VPC AWS credentials env var, adjusts computed job log URLs, and adds a new daily periodic OCM test job that sources secrets and runs Changes
Sequence Diagram(s)sequenceDiagram
participant Scheduler as Prow Scheduler
participant JobPod as Kubernetes Pod (job)
participant Nested as Nested Podman Container
participant Secrets as Mounted Secrets
participant OCM as ocmtest
participant Logs as Prow Logs / Storage
Scheduler->>JobPod: trigger periodic job (cron)
JobPod->>Secrets: read `/var/run/secret/...` (ocm-tokens, jira-cred)
JobPod->>JobPod: build `/tmp/podman.env`
JobPod->>Nested: launch nested podman container (sourced env)
Nested->>Secrets: source credentials (AWS_SHARED_VPC_CREDENTIALS_FILE)
Nested->>OCM: run `ocmtest test --service cms` for cs-ocm-resources-staging-main
OCM->>Logs: emit test logs
JobPod->>Logs: compute JOB_LINK and upload/annotate logs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 8/10 reviews remaining, refill in 10 minutes and 31 seconds. Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`:
- Around line 204-208: The JOB_LINK construction uses the wrong repo slug and
creates double slashes; change the PR branch to use the correct repo slug
"openshift/release" when building the PR log path (replace
"openshift-online_rosa-e2e" with "openshift/release" in the PR branch) and
eliminate double slashes by normalizing concatenation: set JOB_LINK without a
trailing slash (the initial JOB_LINK assignment) or remove leading slashes from
the appended segments so the conditional branches (the code manipulating
JOB_LINK and the "${PULL_NUMBER}" branch) join paths cleanly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 95417ca8-1670-4d74-8a9a-f25b44f4dd70
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-ocm-resources-staging-main |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-ocm-resources-staging-main |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/retest-required |
- SHARED_VPC_AWS_SHARED_CREDENTIALS_FILE -> AWS_SHARED_VPC_CREDENTIALS_FILE - Remove leading / in JOB_LINK paths to avoid double-slash - Use openshift_release in pr-logs path (where Prow runs)
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@dustman9000: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, jfrazierRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Summary
cs-ocm-resources-staging-mainOCM FVT jobocmci-based patternTest plan
make jobsregenerated periodics successfullyocm-backend-tests/data/ci/jobs/cms.ymlentryJira: https://redhat.atlassian.net/browse/OCM-23823
Summary by CodeRabbit