OCM-23803: migrate cs-osd-ccs-gcp-ad-staging-main FVT to Prow

[dustman9000]

Summary

• Add Prow periodic for cs-osd-ccs-gcp-ad-staging-main OCM FVT job
• Migrates from Tekton/Konflux to Prow using nested-podman + ocmci container pattern
• Runs CMS API gating tests (Day1Post, Day2Pre, Day2CH) against staging OCM with OSD CCS GCP AD cluster profile

Details

• Cron: 0 9 * * * (09:00 UTC daily)
• Workflow: cms-gcp-ccs-gating-test
• Jira: https://redhat.atlassian.net/browse/OCM-23803
• Epic: https://redhat.atlassian.net/browse/ROSAENG-391

Test plan

• make jobs generates periodic job correctly
• pj-rehearse passes

Summary by CodeRabbit

• Chores
  • Added CI configuration to run OpenShift ROSA end-to-end tests against OCP 4.22 nightly in staging.
  • Configures a daily scheduled periodic test job that runs in a nested-container environment, with default CPU/memory resource settings and an allocated memory-backed volume.
  • Mounts credentials securely for test execution and produces JIRA-enabled test reports from the e2e workflow.

[openshift-ci-robot]

@dustman9000: This pull request references OCM-23803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Add Prow periodic for cs-osd-ccs-gcp-ad-staging-main OCM FVT job
• Migrates from Tekton/Konflux to Prow using nested-podman + ocmci container pattern
• Runs CMS API gating tests (Day1Post, Day2Pre, Day2CH) against staging OCM with OSD CCS GCP AD cluster profile

Details

• Cron: 0 9 * * * (09:00 UTC daily)
• Workflow: cms-gcp-ccs-gating-test
• Jira: https://redhat.atlassian.net/browse/OCM-23803
• Epic: https://redhat.atlassian.net/browse/ROSAENG-391

Test plan

• make jobs generates periodic job correctly
• pj-rehearse passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Adds a ci-operator YAML to configure a periodic OpenShift ROSA e2e job for the ocm-fvt-osd-gcp-staging variant: sets nested-podman base image and RHEL9 builder, selects OCP 4.22 nightly, applies global resource defaults, defines a cron job that sources credentials and runs ocmtest, and includes generated metadata.

Changes

CI Job Configuration Addition

Layer / File(s)	Summary
Base Images & Build Root ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osd-gcp-staging.yaml	Adds base_images with nested-podman and build_root.image_stream_tag set to builder: ocp/rhel-9-golang-1.24-openshift-4.22.
Release Selection ci-operator/config/openshift-online/rosa-e2e/...ocm-fvt-osd-gcp-staging.yaml	Sets releases.latest.candidate to product: ocp, stream: nightly, version: "4.22".
Resource Defaults ci-operator/config/openshift-online/rosa-e2e/...ocm-fvt-osd-gcp-staging.yaml	Defines default resources for '*': limits.memory: 4Gi, requests.cpu: 100m, requests.memory: 200Mi.
Test Job Definition / Wiring ci-operator/config/openshift-online/rosa-e2e/...ocm-fvt-osd-gcp-staging.yaml	Adds ocm-fvt-periodic-cs-osd-ccs-gcp-ad-staging-main job: enables nested_podman, cron 0 9 * * *, prepares /tmp/podman.env, computes and exports JOB_LINK, sources OCM/Jira credentials from /usr/local/cs-qe-credentials/*, and invokes podman run ... ocmtest test --service cms --job cs-osd-ccs-gcp-ad-staging-main --reportJiraTicket.
Volumes & Secrets ci-operator/config/openshift-online/rosa-e2e/...ocm-fvt-osd-gcp-staging.yaml	Configures a memory_backed_volume of 1Gi and mounts the cs-qe-credentials secret to /usr/local/cs-qe-credentials (read-only) into the pod.
Job Metadata ci-operator/config/openshift-online/rosa-e2e/...ocm-fvt-osd-gcp-staging.yaml	Adds zz_generated_metadata with branch: main, org: openshift-online, repo: rosa-e2e, variant: ocm-fvt-osd-gcp-staging.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'OCM-23803: migrate cs-osd-ccs-gcp-ad-staging-main FVT to Prow' accurately summarizes the main change: migrating a Jira-tracked FVT test from Tekton/Konflux to Prow, which is the core objective of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only CI-operator YAML configuration files, not Ginkgo test code. The custom check for test name stability applies only to Ginkgo test definitions, which are absent here.
Test Structure And Quality	✅ Passed	PR adds CI-operator YAML configuration, not Ginkgo test code. The custom check applies to test code structure (It blocks, BeforeEach, assertions), which is not present here. Check is not applicable.
Microshift Test Compatibility	✅ Passed	PR adds only a CI configuration YAML file for a Prow periodic job running an external OCM container. No new Ginkgo e2e tests are added, so the MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR adds only a CI-operator configuration file (YAML), not new Ginkgo e2e test code. The custom check applies to new Ginkgo tests, so it is not applicable here.
Topology-Aware Scheduling Compatibility	✅ Passed	PR adds CI-operator periodic job configuration (not deployment/operator/controller code). No topology-specific scheduling constraints present. Out of scope for this check.
Ote Binary Stdout Contract	✅ Passed	Custom check is not applicable. The PR adds only a YAML CI-operator configuration file for job orchestration, not Go test binaries or code that would affect OTE binary stdout contracts.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR adds only a CI-operator configuration file (YAML), not Ginkgo e2e tests. The check does not apply to configuration-only changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[dustman9000]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-osd-ccs-gcp-ad-staging-main

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jfrazierRedHat]

/lgtm

[dustman9000]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-osd-ccs-gcp-ad-staging-main

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[tinaafitz]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, jfrazierRedHat, tinaafitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift-online/rosa-e2e/OWNERS [dustman9000]
• ci-operator/jobs/openshift-online/rosa-e2e/OWNERS [dustman9000]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dustman9000]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-osd-ccs-gcp-ad-staging-main

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[dustman9000]

/pj-rehearse ack

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osd-gcp-staging.yaml (1)

29-44: ⚡ Quick win

Add strict shell flags in the heredoc setup block.

At Line 29, adding fail-fast options will surface missing credential files or sourcing errors immediately instead of failing later inside ocmtest.

Suggested fix

   commands: |
     env -i bash --norc --noprofile << 'EOF' > /tmp/podman.env
+    set -euo pipefail
     export AWS_SHARED_CREDENTIALS_FILE=/credentials/aws-cred
     export SHARED_VPC_AWS_SHARED_CREDENTIALS_FILE=/credentials/aws-shared-vpc-credentials
     export ENABLE_JIRA_REPORTING=true

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osd-gcp-staging.yaml`
around lines 29 - 44, The heredoc that writes /tmp/podman.env (the block
beginning with "env -i bash --norc --noprofile << 'EOF'") should enable strict
shell flags so failures while exporting or sourcing credentials surface
immediately; update the heredoc contents to set -euo pipefail (and optionally
IFS=$'\n\t') near the top before exporting AWS_SHARED_CREDENTIALS_FILE and
before the source lines (/usr/local/cs-qe-credentials/ocm-tokens and
/usr/local/cs-qe-credentials/jira-cred) so missing files or errors cause an
immediate exit rather than failing later in ocmtest.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osd-gcp-staging.yaml`:
- Line 57: The cron schedule currently set as "0 8 * * *" is off by one hour;
update the cron field in the YAML (the cron: line in the
openshift-online-rosa-e2e config) to "0 9 * * *" so it runs at 09:00 UTC daily
to match the migration objective. Ensure the single cron: entry is updated and
any related documentation or comments reflecting the schedule are adjusted to
"09:00 UTC" if present.

---

Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osd-gcp-staging.yaml`:
- Around line 29-44: The heredoc that writes /tmp/podman.env (the block
beginning with "env -i bash --norc --noprofile << 'EOF'") should enable strict
shell flags so failures while exporting or sourcing credentials surface
immediately; update the heredoc contents to set -euo pipefail (and optionally
IFS=$'\n\t') near the top before exporting AWS_SHARED_CREDENTIALS_FILE and
before the source lines (/usr/local/cs-qe-credentials/ocm-tokens and
/usr/local/cs-qe-credentials/jira-cred) so missing files or errors cause an
immediate exit rather than failing later in ocmtest.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 56c768fa-ca0a-44c9-b39b-88676319bcf7

📥 Commits

Reviewing files that changed from the base of the PR and between 00342ac and b5b1adf.

📒 Files selected for processing (1)

• ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osd-gcp-staging.yaml

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osd-gcp-staging-ocm-fvt-periodic-cs-osd-ccs-gcp-ad-staging-main	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@dustman9000: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-osd-ccs-gcp-ad-staging-main	de64339	link	unknown	/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-osd-ccs-gcp-ad-staging-main
ci/prow/generated-config	992f29d	link	true	/test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.