Skip to content

NO-JIRA: feat: remove private repo flags#78708

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
eggfoobar:upkeep-edge-tooling
May 5, 2026
Merged

NO-JIRA: feat: remove private repo flags#78708
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
eggfoobar:upkeep-edge-tooling

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

@eggfoobar eggfoobar commented May 1, 2026

edge-tooling repo switched to public visibility, we dont need to attach gh token for cloning anymore

Summary by CodeRabbit

  • Chores
    • Updated internal CI/CD configuration.

Note: This change does not impact end-user functionality.

edge-tooling repo switched to public visibility, we dont need to attach gh token for cloning anymore

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@eggfoobar: This pull request explicitly references no jira issue.

Details

In response to this:

edge-tooling repo switched to public visibility, we dont need to attach gh token for cloning anymore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 029ff8e6-a060-411b-b440-9088ce334a43

📥 Commits

Reviewing files that changed from the base of the PR and between 50ecdbb and 692f046.

⛔ Files ignored due to path filters (3)
  • ci-operator/jobs/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/edge-tooling/.config.prowgen
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift-eng/edge-tooling/.config.prowgen

Walkthrough

Removes configuration metadata from a prowgen configuration file that designated a job as private and exposed. Two lines of configuration are deleted with no functional logic changes.

Changes

Cohort / File(s) Summary
Configuration Metadata Removal
ci-operator/config/openshift-eng/edge-tooling/.config.prowgen
Deletes job privacy and exposure configuration metadata (2 lines removed).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Topology-Aware Scheduling Compatibility ❓ Inconclusive Unable to determine verification status - shell command execution not available in this environment Please provide the actual PR changes or file contents to verify against requirements
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing private repo flags from a configuration file after the edge-tooling repository was switched to public visibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR does not contain any Ginkgo test code; only CI configuration and documentation files were modified.
Test Structure And Quality ✅ Passed This pull request is not applicable to the custom check for Ginkgo test structure and quality. The PR only modifies CI operator configuration files (.config.prowgen metadata files), removing private repository flags for the edge-tooling repository which has been switched to public visibility. The changes contain no Go test files, no Ginkgo test code, and no test-related modifications. Since no Ginkgo tests are present in this PR, the test quality review requirements do not apply.
Microshift Test Compatibility ✅ Passed This PR only modifies CI configuration metadata files and does not add any Ginkgo e2e tests, so the check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies CI configuration files to remove private repo flags; no new Ginkgo e2e tests are added or modified.
Ote Binary Stdout Contract ✅ Passed PR modifies CI configuration file (.config.prowgen), not Go source code, so OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies CI configuration files and does not add any new Ginkgo e2e tests, so the custom check for IPv6 and disconnected network compatibility does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jerpeter1 and kasturinarra May 1, 2026 22:02
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@eggfoobar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-edge-tooling-main-images openshift-eng/edge-tooling presubmit Presubmit changed
pull-ci-openshift-eng-edge-tooling-main-markdownlint openshift-eng/edge-tooling presubmit Presubmit changed
pull-ci-openshift-eng-edge-tooling-main-shellcheck openshift-eng/edge-tooling presubmit Presubmit changed
periodic-ci-openshift-eng-edge-tooling-main-ocp-ci-monitor N/A periodic Periodic changed
periodic-ci-openshift-eng-edge-tooling-main-pr-notifier N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 2, 2026
@pmtk
Copy link
Copy Markdown
Member

pmtk commented May 5, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit ebf43aa into openshift:main May 5, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants