sonic/config_generator: use "up" for BGP_NEIGHBOR_AF admin_status

[berendt]

_add_bgp_configurations wrote "admin_status": "true" for every BGP_NEIGHBOR_AF row it generated: ipv4_unicast, ipv6_unicast and l2vpn_evpn keys for both interfaces and port channels, plus the VLAN peer ipv4_unicast row. The schema enforced by the new Pydantic validator (BgpNeighborAfListRow.admin_status) is Literal["up", "down"], so validation rejected every generated row with "Input should be 'up' or 'down'".

Replace the literal "true" with "up" at all seven call sites. Same fix pattern as #2260, which aligned other generated values with the schema.

AI-assisted: Claude Code

[sourcery-ai]

Hey - I've left some high level feedback:

• Since admin_status is now constrained to "up"/"down", consider centralizing these values in a small helper or constant to avoid future drift if the schema changes again.
• It may be worth scanning for any remaining hard-coded boolean-like strings in related BGP config generation paths to ensure they consistently match the new Pydantic Literal["up", "down"] expectations.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Since `admin_status` is now constrained to "up"/"down", consider centralizing these values in a small helper or constant to avoid future drift if the schema changes again.
- It may be worth scanning for any remaining hard-coded boolean-like strings in related BGP config generation paths to ensure they consistently match the new Pydantic `Literal["up", "down"]` expectations.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[berendt]

Depends on #2258

[osfrickler]

I'm not convinced that this is a good idea, operationally it is better to stick to the values that a config save on the running switch generates, so that it is easy to spot actual config changes. If the scheme we use for verification doesn't match this, then IMO the scheme is wrong, not the generated config.