refactor(modules): split adapters, examples, and adapter tests into separate Go modules#28
Closed
codercms wants to merge 2 commits into
Closed
refactor(modules): split adapters, examples, and adapter tests into separate Go modules#28codercms wants to merge 2 commits into
codercms wants to merge 2 commits into
Conversation
…eparate Go modules Move optional integrations into dedicated modules so the core package remains focused. This keeps dependency resolution scoped to each use case and clarifies module boundaries.
codercms
force-pushed
the
feature/go-mod-split
branch
from
8396199 to
2825513
Compare
Member
|
Hi @codercms, thanks for the PR. Switched from packages to modules in the commit above. |
Contributor
Author
|
@ankane got it. |
Member
|
The Go version bump was intentional and done in a previous commit (b69346a). Also, I think it's fine to use version 0.4.0 for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move optional integrations into dedicated modules so the core package remains focused.
This keeps dependency resolution scoped to each use case and clarifies module boundaries.
It means that the for pgx users there's no need to resolve deps such as gorm, pg-go, bun, sqlx, etc