fix(ci): make abi3audit step OS-aware (fix Windows wheel-build job)#655
Open
fix(ci): make abi3audit step OS-aware (fix Windows wheel-build job)#655
Conversation
Use RUNNER_TEMP instead of /tmp for the venv parent, and detect Scripts/ (Windows) vs bin/ (Linux/macOS) for the binary directory. Fixes exit code 127 on x86_64-pc-windows-msvc runners where Git Bash maps /tmp to a different path than RUNNER_TEMP, and Windows venvs place binaries in Scripts/ not bin/. Closes CI-0060.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tmp/abi3audit-venv/bin/...paths with OS-aware equivalents$RUNNER_TEMPinstead of/tmpfor the venv parent (works on all runner OSes)Scripts/(Windows) vsbin/(Linux/macOS) for the binary directoryx86_64-pc-windows-msvcrunners (CI-0060)Root cause
The
abi3auditstep (lines 416–422) hardcoded Unix-style paths. On Windows runners:/tmpto a runner-specificAppData/Local/Temppath, notRUNNER_TEMPScripts/, notbin/This combination caused "No such file or directory" / exit 127 on every Windows wheel build.
Verification
Release Readiness run on this branch with
skip_integration=true:https://github.com/pinecone-io/python-sdk/actions/runs/25521225781
All wheel build jobs green, including
Wheel build (x86_64-pc-windows-msvc). CI-0037's isolation intent (separate venv for abi3audit) is preserved.Note
Low Risk
Low risk workflow tweak that only changes how the
abi3auditvirtualenv is created/invoked; main risk is CI regressions if path detection or$RUNNER_TEMPbehaves unexpectedly on some runners.Overview
Fixes the
release-readinesswheel-build job’sabi3auditstep to work cross-platform by creating the venv underRUNNER_TEMPand selectingScripts/(Windows) vsbin/(Unix) when invokingpip/python.This removes hardcoded
/tmp/.../bin/...paths, preventing Windows wheel builds from failing with missing executable/path errors while preserving the venv isolation intent.Reviewed by Cursor Bugbot for commit 1747670. Bugbot is set up for automated code reviews on this repo. Configure here.