chore: replace deprecated PingCAP download domains#12582
chore: replace deprecated PingCAP download domains#12582
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. |
| local download_urls=( | ||
| "${FILE_SERVER_URL}/download/builds/pingcap/tidb/${tidb_sha1}/centos7/tidb-server.tar.gz" | ||
| "http://download.pingcap.org/tidb-enterprise-tools-latest-linux-amd64.tar.gz" | ||
| "http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz" |
There was a problem hiding this comment.
For security reasons, it's strongly recommended to use https instead of http when downloading binaries. This helps prevent man-in-the-middle attacks where an attacker could substitute the binary with a malicious one.
| "http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz" | |
| "https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #12582 +/- ##
===========================================
Coverage ? 49.5136%
===========================================
Files ? 487
Lines ? 70730
Branches ? 0
===========================================
Hits ? 35021
Misses ? 32950
Partials ? 2759 🚀 New features to boost your workflow:
|
|
@wuhuizuo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
download.pingcap.orgreferences withdownload.pingcap.comcharts.pingcap.orgreferences withcharts.pingcap.comwhere presentValidation
git diff --checkdownload.pingcap.org/charts.pingcap.orgreferences in the patched branch