Skip to content

chore: replace deprecated PingCAP download domains#12582

Open
wuhuizuo wants to merge 1 commit intomasterfrom
fix/update-download-domains-master
Open

chore: replace deprecated PingCAP download domains#12582
wuhuizuo wants to merge 1 commit intomasterfrom
fix/update-download-domains-master

Conversation

@wuhuizuo
Copy link
Copy Markdown
Contributor

@wuhuizuo wuhuizuo commented Apr 2, 2026

Summary

  • replace deprecated download.pingcap.org references with download.pingcap.com
  • replace deprecated charts.pingcap.org references with charts.pingcap.com where present
  • keep the existing paths and protocols unchanged

Validation

  • git diff --check
  • verified no remaining download.pingcap.org / charts.pingcap.org references in the patched branch

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 2, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 2, 2026

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added area/dm Issues or PRs related to DM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates download URLs from the .org domain to the .com domain across documentation and scripts. A security improvement was suggested to use HTTPS instead of HTTP for a specific download link to mitigate man-in-the-middle risks.

local download_urls=(
"${FILE_SERVER_URL}/download/builds/pingcap/tidb/${tidb_sha1}/centos7/tidb-server.tar.gz"
"http://download.pingcap.org/tidb-enterprise-tools-latest-linux-amd64.tar.gz"
"http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

For security reasons, it's strongly recommended to use https instead of http when downloading binaries. This helps prevent man-in-the-middle attacks where an attacker could substitute the binary with a malicious one.

Suggested change
"http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz"
"https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz"

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@7d85ef4). Learn more about missing BASE report.
⚠️ Report is 11 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc ∅ <ø> (?)
dm 49.1114% <ø> (?)
engine 50.7167% <ø> (?)
Flag Coverage Δ
unit 49.5136% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@             Coverage Diff             @@
##             master     #12582   +/-   ##
===========================================
  Coverage          ?   49.5136%           
===========================================
  Files             ?        487           
  Lines             ?      70730           
  Branches          ?          0           
===========================================
  Hits              ?      35021           
  Misses            ?      32950           
  Partials          ?       2759           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 2, 2026

@wuhuizuo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-cdc cbe00c3 link true /test pull-unit-test-cdc
pull-dm-integration-test cbe00c3 link true /test pull-dm-integration-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dm Issues or PRs related to DM. do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant