Skip to content

logging(cdc): improve cdc logging quality and reduce log message count#12591

Open
3AceShowHand wants to merge 24 commits intopingcap:masterfrom
3AceShowHand:logging-quality-improvement
Open

logging(cdc): improve cdc logging quality and reduce log message count#12591
3AceShowHand wants to merge 24 commits intopingcap:masterfrom
3AceShowHand:logging-quality-improvement

Conversation

@3AceShowHand
Copy link
Copy Markdown
Contributor

@3AceShowHand 3AceShowHand commented Apr 7, 2026

What problem does this PR solve?

Issue Number: close #11948, close #12588

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 7, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign suzaku for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 7, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sarama dependency to version v1.41.2-pingcap-20251202-x. Feedback was provided regarding the use of the -x suffix in the version tag, suggesting that a standard versioning scheme should be used for production-grade repositories to ensure stability and reproducibility.

Comment thread go.mod
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2026
@ti-chi-bot ti-chi-bot Bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2026
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 9, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 13, 2026

@3AceShowHand: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-build 1895a44 link true /test pull-build
pull-unit-test-cdc 1895a44 link true /test pull-unit-test-cdc
pull-check 1895a44 link true /test pull-check
pull-dm-integration-test 1895a44 link true /test pull-dm-integration-test
pull-cdc-integration-mysql-test 1895a44 link true /test pull-cdc-integration-mysql-test
pull-cdc-integration-kafka-test 1895a44 link true /test pull-cdc-integration-kafka-test
pull-dm-integration-test-next-gen 1895a44 link false /test pull-dm-integration-test-next-gen
pull-syncdiff-integration-test 1895a44 link true /test pull-syncdiff-integration-test
pull-dm-compatibility-test 1895a44 link true /test pull-dm-compatibility-test
pull-cdc-integration-pulsar-test 1895a44 link true /test pull-cdc-integration-pulsar-test
pull-error-log-review 1895a44 link true /test pull-error-log-review
pull-verify 1895a44 link true /test pull-verify
pull-cdc-integration-storage-test 1895a44 link true /test pull-cdc-integration-storage-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disk may full if print too many log Remove the "event feed starts to check locked regions" log 🔥🔥🔥

1 participant