Skip to content

GH-146128: Remove the buggy AArch64 "33rx" relocation#146263

Merged
hugovk merged 2 commits intopython:mainfrom
brandtbucher:fix-aarch64-33rx
Apr 7, 2026
Merged

GH-146128: Remove the buggy AArch64 "33rx" relocation#146263
hugovk merged 2 commits intopython:mainfrom
brandtbucher:fix-aarch64-33rx

Conversation

@brandtbucher
Copy link
Copy Markdown
Member

@brandtbucher brandtbucher commented Mar 21, 2026 •
edited by bedevere-app bot
Loading

@brandtbucher brandtbucher self-assigned this Mar 21, 2026
@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.13 bugs and security fixes topic-JIT needs backport to 3.14 bugs and security fixes labels Mar 21, 2026
@bedevere-app bedevere-app bot mentioned this pull request Mar 21, 2026
Open
@diegorusso
Copy link
Copy Markdown
Contributor

diegorusso commented Apr 1, 2026

Did you have a chance to measure performance impact?

@brandtbucher
Copy link
Copy Markdown
Member Author

brandtbucher commented Apr 1, 2026

I'm not too concerned with performance impact because it's a correctness issue. But we can run it if we're curious.

@brandtbucher
Copy link
Copy Markdown
Member Author

brandtbucher commented Apr 1, 2026

But even if it's, say, 1% slower, the right thing to do is rip this out from existing branches and do something better in the textual assembly pass in 3.15.

@markshannon
Copy link
Copy Markdown
Member

markshannon commented Apr 2, 2026

I'd like to handle the relocations properly, rather than just remove it.

I've made the issue a blocker. If we can't do it properly before the release, we can merge this.

@hugovk
Copy link
Copy Markdown
Member

hugovk commented Apr 6, 2026

Ready to merge for tomorrow's releases?

@hugovk hugovk merged commit 6bb7b33 into python:main Apr 7, 2026
89 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 7, 2026

Thanks @brandtbucher for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 7, 2026

Sorry, @brandtbucher and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6bb7b33e8f8e1640e284aeb24bf90292df6a8187 3.14

@miss-islington-app miss-islington-app bot assigned hugovk and unassigned brandtbucher Apr 7, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 7, 2026

Sorry, @brandtbucher and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6bb7b33e8f8e1640e284aeb24bf90292df6a8187 3.13

hugovk pushed a commit to hugovk/cpython that referenced this pull request Apr 7, 2026
@brandtbucher @hugovk
[3.14] pythonGH-146128: Remove the buggy AArch64 "33rx" relocation (p…
392153b 
…ythonGH-146263)

(cherry picked from commit 6bb7b33)

Co-authored-by: Brandt Bucher <brandt@python.org>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 7, 2026

GH-148198 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Apr 7, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 7, 2026

GH-148199 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 7, 2026
hugovk pushed a commit to hugovk/cpython that referenced this pull request Apr 7, 2026
@brandtbucher @hugovk
pythonGH-146128: Remove the buggy AArch64 "33rx" relocation (python#1…
9e1b5c3 
…46263)

(cherry picked from commit 6bb7b33)
hugovk pushed a commit to hugovk/cpython that referenced this pull request Apr 7, 2026
@brandtbucher @hugovk
pythonGH-146128: Remove the buggy AArch64 "33rx" relocation (python#1…
255595d 
…46263)

(cherry picked from commit 6bb7b33)
hugovk added a commit that referenced this pull request Apr 7, 2026
@hugovk @brandtbucher
[3.14] GH-146128: Remove the buggy AArch64 "33rx" relocation (GH-146263…
383c291 
…) (#148198)

Co-authored-by: Brandt Bucher <brandt@python.org>
@markshannon
Copy link
Copy Markdown
Member

markshannon commented Apr 7, 2026

I don't think this should have been merged.
I marked the issue as a deferred blocker, as it is only a potential bug, not an actual one.

Yhg1s pushed a commit that referenced this pull request Apr 7, 2026
@hugovk @brandtbucher @Fidget-Spinner
[3.13] GH-146128: Remove the buggy AArch64 "33rx" relocation (#146263) (
8a0993f 
#148199)

GH-146128: Remove the buggy AArch64 "33rx" relocation (#146263)

(cherry picked from commit 6bb7b33)

Co-authored-by: Brandt Bucher <brandt@python.org>
Co-authored-by: Ken Jin <kenjin@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

@diegorusso diegorusso Awaiting requested review from diegorusso diegorusso is a code owner

Assignees

@hugovk hugovk

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brandtbucher @diegorusso @markshannon @hugovk @savannahostrowski