Conversation
frival
added
the
group_review_lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do? Give a short summary
Uses error_codes found in test_tools/error_codes to provide more specific error indication.
Before/After Comparison
After: Error codes are now bases on test_tools/error_codes, making it easier to limit when we do a rerun of the test.
Also, changed how we load in test_tools, we try curl, git, and wget, to avoid a failure due to the program not
being installed.
Clerical Stuff
This closes #60
Relates to JIRA: RPOPC-868
Testing
Ran through zathras, with following scenario file
global:
ssh_key_file: replace_your_ssh_key
terminate_cloud: 0
os_vendor: rhel
results_prefix: phor_results
os_vendor: rhel
system_type: aws
cloud_os_id: ami-035032ea878eca201
systems:
system1:
tests: "phoronix_phpbench"
host_config: "m5.xlarge"
csv results
Average,Deviation,Start_Date,End_Date
530679,0.09,2026-03-13T13:28:39Z,2026-03-13T13:30:47Z
Returned 0 as expected. Testing on rerun verification handled in the appropriate zathras pr.